RESOLVED FIXED 148747
[Win] Implement DOMNode::attributes. 
https://bugs.webkit.org/show_bug.cgi?id=148747
Summary [Win] Implement DOMNode::attributes.
peavo
Reported 2015-09-03 12:20:28 PDT
This method is not implemented on Windows.
Attachments
Patch (8.08 KB, patch)
2015-09-03 12:23 PDT, peavo 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2015-09-03 12:23:30 PDT
Created attachment 260508 [details] Patch
Brent Fulgham
Comment 2 2015-09-08 09:22:12 PDT
Comment on attachment 260508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260508&action=review Looks great! > Source/WebKit/win/DOMCoreClasses.cpp:218 > + *result = 0; Why not nullptr?
peavo
Comment 3 2015-09-08 09:35:49 PDT
(In reply to comment #2) > Comment on attachment 260508 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260508&action=review > > Looks great! > > > Source/WebKit/win/DOMCoreClasses.cpp:218 > > + *result = 0; > > Why not nullptr? Thanks! Will update before landing :)
peavo
Comment 4 2015-09-08 11:21:23 PDT
Committed r189497: <http://trac.webkit.org/changeset/189497>.
Note You need to log in before you can comment on or make changes to this bug.