Bug 148747 - [Win] Implement DOMNode::attributes.
Summary: [Win] Implement DOMNode::attributes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-03 12:20 PDT by peavo
Modified: 2015-09-08 11:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.08 KB, patch)
2015-09-03 12:23 PDT, peavo
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-09-03 12:20:28 PDT
This method is not implemented on Windows.
Comment 1 peavo 2015-09-03 12:23:30 PDT
Created attachment 260508 [details]
Patch
Comment 2 Brent Fulgham 2015-09-08 09:22:12 PDT
Comment on attachment 260508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260508&action=review

Looks great!

> Source/WebKit/win/DOMCoreClasses.cpp:218
> +    *result = 0;

Why not nullptr?
Comment 3 peavo 2015-09-08 09:35:49 PDT
(In reply to comment #2)
> Comment on attachment 260508 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260508&action=review
> 
> Looks great!
> 
> > Source/WebKit/win/DOMCoreClasses.cpp:218
> > +    *result = 0;
> 
> Why not nullptr?

Thanks! Will update before landing :)
Comment 4 peavo 2015-09-08 11:21:23 PDT
Committed r189497: <http://trac.webkit.org/changeset/189497>.