Bug 148730 – Web Inspector: Update jsmin.py to 2.1.4

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Web Inspector

[Blaze Burg]

The new version has a handy quote_chars= option. If you add backtick as a quoting character, it fixes Bug 148728.

[Radar WebKit Bug Importer]

<rdar://problem/22550479>

[Blaze Burg]

Created attachment 260458 [details]
Updated jsmin.py

Cannot be committed until use of new version is approved.

[WebKit Commit Bot]

Attachment 260458 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:5:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:7:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:14:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:17:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:47:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:76:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:79:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/jsmin.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:5:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:7:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:14:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:17:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:47:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:76:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:79:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebInspectorUI/Scripts/jsmin.py:107:  trailing whitespace  [pep8/W291] [5]
Total errors found: 16 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 260458 [details]
Updated jsmin.py

Attachment 260458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/134723

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 260464 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Joseph Pecoraro]

So this is interesting. Is there a jasmine for ES6. If not, maybe we want to switch to a compatible minified that better supports ES6 syntax, because we are making heavy use of it.

[Build Bot]

Comment on attachment 260458 [details]
Updated jsmin.py

Attachment 260458 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/134786

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 260470 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Joseph Pecoraro]

(In reply to comment #6)
> Is there a jasmine

Is there a *jsmin*

[Joseph Pecoraro]

rs=me pending approval.

Weird that tests are failing on multiple bots though...

[Joseph Pecoraro]

Comment on attachment 260458 [details]
Updated jsmin.py

I wonder how this is making our tests crash? Seems worth investigating.

[Blaze Burg]

(In reply to comment #11)
> Comment on attachment 260458 [details]
> Updated jsmin.py
> 
> I wonder how this is making our tests crash? Seems worth investigating.

My guess is broken InjectedScriptSource.js or something. Will look at it.

[Blaze Burg]

Yup, the new version of jsmin.py fails to correctly minify our existing InjectedScriptSource.js file. There's no obvious bug, so maybe I'll just abandon this for now.

Yusuke found out that we could use UglifyJS2 via Browserify, but this is dependent on vending InjectedScriptSource.js from WebInspectorUI. Otherwise, there will be a circular dependency on jsc.