RESOLVED FIXED 148724
[iOS] Playback does not pause when deselecting route and locking screen. 
https://bugs.webkit.org/show_bug.cgi?id=148724
Summary [iOS] Playback does not pause when deselecting route and locking screen.
Jer Noble
Reported 2015-09-02 14:15:53 PDT
[iOS] Playback does not pause when deselecting route and locking screen.
Attachments
Patch (9.78 KB, patch)
2015-09-02 16:09 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (8.19 KB, patch)
2015-09-02 16:25 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-09-02 15:14:25 PDT
<rdar://problem/22100651>
Jer Noble
Comment 2 2015-09-02 16:09:05 PDT
Created attachment 260449 [details] Patch
Eric Carlson
Comment 3 2015-09-02 16:23:32 PDT
Comment on attachment 260449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260449&action=review > Source/WebCore/html/MediaElementSession.cpp:295 > + bool oldHasActiveRoute = m_playbackTarget && m_playbackTarget->hasActiveRoute(); > + bool newHasActiveRoute = device->hasActiveRoute(); > m_playbackTarget = WTF::move(device); > client().setWirelessPlaybackTarget(*m_playbackTarget.copyRef()); > + if (oldHasActiveRoute != newHasActiveRoute) > + isPlayingToWirelessPlaybackTargetChanged(newHasActiveRoute); as discussed on irc, this isn't correct or necessary for iOS. > Source/WebCore/platform/audio/PlatformMediaSessionManager.h:61 > + bool isApplicationInBackground() const { return m_isApplicationInBackground; } Nit: this isn't used.
Jer Noble
Comment 4 2015-09-02 16:25:44 PDT
Created attachment 260453 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-09-03 16:53:39 PDT
Comment on attachment 260453 [details] Patch for landing Clearing flags on attachment: 260453 Committed r189322: <http://trac.webkit.org/changeset/189322>
Note You need to log in before you can comment on or make changes to this bug.