Bug 148716 - MutationObserver should accept attributeFilter, attributeOldValue, and characterDataOldValue on their own
Summary: MutationObserver should accept attributeFilter, attributeOldValue, and charac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2015-09-02 10:31 PDT by Ryosuke Niwa
Modified: 2015-09-02 20:08 PDT (History)
6 users (show)

See Also:

Attachments
Fixes the bug (9.11 KB, patch)
2015-09-02 10:38 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-02 10:31:19 PDT 
Right now MutationObserver require attributes to be present when attributeFilter and attributeOldValue are set,
and characterData when characterDataOldValue is set but DOM4 implicitly set those attributes now.
Comment 1 Ryosuke Niwa 2015-09-02 10:38:24 PDT 
Created attachment 260424 [details]
Fixes the bug
Comment 2 Chris Dumez 2015-09-02 10:47:59 PDT 
Comment on attachment 260424 [details]
Fixes the bug

r=me
Comment 3 Ryosuke Niwa 2015-09-02 13:51:21 PDT 
<rdar://problem/22545128>
Comment 4 WebKit Commit Bot 2015-09-02 15:42:06 PDT 
Comment on attachment 260424 [details]
Fixes the bug

Rejecting attachment 260424 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260424, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/134352
Comment 5 WebKit Commit Bot 2015-09-02 20:08:20 PDT 
Comment on attachment 260424 [details]
Fixes the bug

Clearing flags on attachment: 260424

Committed r189271: <http://trac.webkit.org/changeset/189271>
Comment 6 WebKit Commit Bot 2015-09-02 20:08:34 PDT 
All reviewed patches have been landed.  Closing bug.