Bug 148700 - [Mac] Add support for testing swipes
Summary: [Mac] Add support for testing swipes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-01 19:31 PDT by Tim Horton
Modified: 2024-07-17 12:27 PDT (History)
11 users (show)

See Also:


Attachments
Patch (42.00 KB, patch)
2015-09-01 19:32 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
patch again for ews (42.00 KB, patch)
2015-09-02 22:56 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (44.76 KB, patch)
2015-09-02 23:54 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (545.90 KB, application/zip)
2015-09-03 00:27 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (585.40 KB, application/zip)
2015-09-03 00:34 PDT, Build Bot
no flags Details
Patch (53.30 KB, patch)
2015-09-03 11:23 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (616.40 KB, application/zip)
2015-09-03 12:03 PDT, Build Bot
no flags Details
Patch (56.85 KB, patch)
2015-09-03 13:26 PDT, Tim Horton
bdakin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (590.85 KB, application/zip)
2015-09-03 14:04 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-01 19:31:40 PDT
[Mac] Add support for testing swipes
Comment 1 Tim Horton 2015-09-01 19:32:14 PDT
Created attachment 260402 [details]
Patch
Comment 2 Tim Horton 2015-09-01 19:32:44 PDT
This probably won't build because it depends on https://bugs.webkit.org/show_bug.cgi?id=148693
Comment 3 Tim Horton 2015-09-01 19:33:24 PDT
Need to test on some other version of OS X (Mavericks?) and also make it possible to toggle swipe on/off from JS (because now it's hard-coded to on).
Comment 4 Tim Horton 2015-09-02 22:56:23 PDT
Created attachment 260489 [details]
patch again for ews
Comment 5 WebKit Commit Bot 2015-09-02 22:59:31 PDT
Attachment 260489 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2015-09-02 23:54:58 PDT
Created attachment 260492 [details]
Patch
Comment 7 Build Bot 2015-09-03 00:27:16 PDT
Comment on attachment 260492 [details]
Patch

Attachment 260492 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/135628

New failing tests:
swipe/basic-cached-back-swipe.html
Comment 8 Build Bot 2015-09-03 00:27:21 PDT
Created attachment 260493 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 9 Build Bot 2015-09-03 00:34:08 PDT
Comment on attachment 260492 [details]
Patch

Attachment 260492 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/135639

New failing tests:
swipe/basic-cached-back-swipe.html
Comment 10 Build Bot 2015-09-03 00:34:13 PDT
Created attachment 260494 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 11 Tim Horton 2015-09-03 11:23:21 PDT
Created attachment 260497 [details]
Patch
Comment 12 Build Bot 2015-09-03 12:03:44 PDT
Comment on attachment 260497 [details]
Patch

Attachment 260497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/137132

New failing tests:
swipe/basic-cached-back-swipe.html
Comment 13 Build Bot 2015-09-03 12:03:48 PDT
Created attachment 260507 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 14 Tim Horton 2015-09-03 13:26:04 PDT
Created attachment 260515 [details]
Patch
Comment 15 WebKit Commit Bot 2015-09-03 13:29:34 PDT
Attachment 260515 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:95:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Build Bot 2015-09-03 14:04:21 PDT
Comment on attachment 260515 [details]
Patch

Attachment 260515 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/137437

New failing tests:
swipe/basic-cached-back-swipe.html
Comment 17 Build Bot 2015-09-03 14:04:26 PDT
Created attachment 260520 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 18 Tim Horton 2015-09-03 14:12:26 PDT
http://trac.webkit.org/changeset/189287
Comment 19 Radar WebKit Bug Importer 2024-07-17 12:27:43 PDT
<rdar://problem/131945393>