Bug 148694 - Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec
Summary: Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2015-09-01 16:38 PDT by Ryosuke Niwa
Modified: 2015-09-01 19:32 PDT (History)
7 users (show)

See Also:


Attachments
Refactoring (19.81 KB, patch)
2015-09-01 16:42 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (614.58 KB, application/zip)
2015-09-01 17:17 PDT, Build Bot
no flags Details
Addresses the review comment (3.96 KB, patch)
2015-09-01 19:29 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-01 16:38:43 PDT
ShadowHost::hostElement has been renamed to ShadowRost::host in the latest shadow DOM spec. Match that.
Comment 1 Ryosuke Niwa 2015-09-01 16:42:06 PDT
Created attachment 260393 [details]
Refactoring
Comment 2 Chris Dumez 2015-09-01 16:48:06 PDT
Comment on attachment 260393 [details]
Refactoring

View in context: https://bugs.webkit.org/attachment.cgi?id=260393&action=review

r=me % nits.

> Source/WebCore/dom/Element.cpp:1663
> +    oldRoot->setHost(0);

nullptr

> Source/WebCore/dom/Node.cpp:1038
>      return 0;

nullptr

> Source/WebCore/dom/ShadowRoot.h:56
> +    Element* host() const { return m_hostElement; }

So we don't want to rename the member variable as well?
Comment 3 Build Bot 2015-09-01 17:17:49 PDT
Comment on attachment 260393 [details]
Refactoring

Attachment 260393 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/131220

New failing tests:
http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html
Comment 4 Build Bot 2015-09-01 17:17:52 PDT
Created attachment 260395 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Chris Dumez 2015-09-01 17:21:18 PDT
(In reply to comment #3)
> Comment on attachment 260393 [details]
> Refactoring
> 
> Attachment 260393 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/131220
> 
> New failing tests:
> http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html

This is a flake.
Comment 6 WebKit Commit Bot 2015-09-01 17:55:07 PDT
Comment on attachment 260393 [details]
Refactoring

Clearing flags on attachment: 260393

Committed r189239: <http://trac.webkit.org/changeset/189239>
Comment 7 WebKit Commit Bot 2015-09-01 17:55:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Chris Dumez 2015-09-01 18:30:11 PDT
(In reply to comment #6)
> Comment on attachment 260393 [details]
> Refactoring
> 
> Clearing flags on attachment: 260393
> 
> Committed r189239: <http://trac.webkit.org/changeset/189239>

What about my nit fixes?
Comment 9 Ryosuke Niwa 2015-09-01 18:49:59 PDT
Oh oops, I missed your comments.  Will fix in a minute.
Comment 10 Ryosuke Niwa 2015-09-01 19:29:47 PDT
Reopening to attach new patch.
Comment 11 Ryosuke Niwa 2015-09-01 19:29:49 PDT
Created attachment 260401 [details]
Addresses the review comment
Comment 12 Ryosuke Niwa 2015-09-01 19:31:57 PDT
Comment on attachment 260401 [details]
Addresses the review comment

Clearing flags on attachment: 260401

Committed r189243: <http://trac.webkit.org/changeset/189243>
Comment 13 Ryosuke Niwa 2015-09-01 19:32:03 PDT
All reviewed patches have been landed.  Closing bug.