Bug 148694 – Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

ShadowHost::hostElement has been renamed to ShadowRost::host in the latest shadow DOM spec. Match that.

[Ryosuke Niwa]

Created attachment 260393 [details]
Refactoring

[Chris Dumez]

Comment on attachment 260393 [details]
Refactoring

View in context: https://bugs.webkit.org/attachment.cgi?id=260393&action=review

r=me % nits.

> Source/WebCore/dom/Element.cpp:1663
> +    oldRoot->setHost(0);

nullptr

> Source/WebCore/dom/Node.cpp:1038
>      return 0;

nullptr

> Source/WebCore/dom/ShadowRoot.h:56
> +    Element* host() const { return m_hostElement; }

So we don't want to rename the member variable as well?

[Build Bot]

Comment on attachment 260393 [details]
Refactoring

Attachment 260393 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/131220

New failing tests:
http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html

[Build Bot]

Created attachment 260395 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Chris Dumez]

(In reply to comment #3)
> Comment on attachment 260393 [details]
> Refactoring
> 
> Attachment 260393 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/131220
> 
> New failing tests:
> http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html

This is a flake.

[WebKit Commit Bot]

Comment on attachment 260393 [details]
Refactoring

Clearing flags on attachment: 260393

Committed r189239: <http://trac.webkit.org/changeset/189239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

(In reply to comment #6)
> Comment on attachment 260393 [details]
> Refactoring
> 
> Clearing flags on attachment: 260393
> 
> Committed r189239: <http://trac.webkit.org/changeset/189239>

What about my nit fixes?

[Ryosuke Niwa]

Oh oops, I missed your comments.  Will fix in a minute.

[Ryosuke Niwa]

Reopening to attach new patch.

[Ryosuke Niwa]

Created attachment 260401 [details]
Addresses the review comment

[Ryosuke Niwa]

Comment on attachment 260401 [details]
Addresses the review comment

Clearing flags on attachment: 260401

Committed r189243: <http://trac.webkit.org/changeset/189243>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.