Bug 148689 – [ES6] Enable ES6 Module in JSC shell by default

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

Since the entry point to evaluate the modules are completely separated from the usual entry point to evaluate the script,
we can safely enable ES6 modules in JSC shell.

[Yusuke Suzuki]

Created attachment 260439 [details]
Patch

[Yusuke Suzuki]

This patch is based on the https://bugs.webkit.org/show_bug.cgi?id=148705 and https://bugs.webkit.org/show_bug.cgi?id=148053.

[Yusuke Suzuki]

Created attachment 260571 [details]
Patch

[Geoffrey Garen]

Comment on attachment 260571 [details]
Patch

r=me

[Yusuke Suzuki]

Committed r189431: <http://trac.webkit.org/changeset/189431>

[Csaba Osztrogonác]

(In reply to comment #5)
> Committed r189431: <http://trac.webkit.org/changeset/189431>

There are 162 failures on the Apple Windows buildbots.

[Yusuke Suzuki]

(In reply to comment #6)
> (In reply to comment #5)
> > Committed r189431: <http://trac.webkit.org/changeset/189431>
> 
> There are 162 failures on the Apple Windows buildbots.

I'll look into it.

[Yusuke Suzuki]

Ah, ok. I've found the problem.
Now, we specify the module path with UNIX path separator like,

`import A from "A/main.js"`.

We already represents the current path with `\\` style.
However, when concatenating the current path + the module path,
we did not convert the module path to `\\` style.
This causes the incorrect path like,

`C:\cygwin\home\buildbot\slave\win-debug-tests\build\WebKitBuild\Debug\bin32\jsc-stress-results\.tests\modules.yaml\modules\im\./resources/assert.js`

I'll submit the unreviewed attempt to fix patch.

[Yusuke Suzuki]

The incorrect path peoblem seems solved.
But it seems that the current working directory path seems truncated.
I'll now checking...
(I guess it is due to too long path name)

[Yusuke Suzuki]

OK, the problem is,
the max path of the Windows is limited and short (260),
Modules in JSC shell uses an absolute path as an unique key to each module, so files are opened by an absolute path. Do, when getting the current working directory, the path is truncated.
Now in the meantime, we will skip them in Windows.
Later, I'll fix the problem and enable the tests in Windows.

[Yusuke Suzuki]

Committed r189453: <http://trac.webkit.org/changeset/189453>