Bug 148679 - Web Inspector: protocol generator should not allow non-boolean values for "optional" key
Summary: Web Inspector: protocol generator should not allow non-boolean values for "op...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: InspectorProtocol
  Show dependency tree / graph
 
Reported: 2015-09-01 08:50 PDT by BJ Burg
Modified: 2015-09-01 11:45 PDT (History)
8 users (show)

See Also:

Attachments
Proposed Fix (5.34 KB, patch)
2015-09-01 11:18 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-09-01 08:50:00 PDT 
Whoops
Comment 1 Radar WebKit Bug Importer 2015-09-01 08:50:49 PDT 
<rdar://problem/22518956>
Comment 2 BJ Burg 2015-09-01 11:18:39 PDT 
Created attachment 260375 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2015-09-01 11:20:37 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Joseph Pecoraro 2015-09-01 11:22:42 PDT 
Comment on attachment 260375 [details]
Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2015-09-01 11:45:20 PDT 
Comment on attachment 260375 [details]
Proposed Fix

Clearing flags on attachment: 260375

Committed r189222: <http://trac.webkit.org/changeset/189222>
Comment 6 WebKit Commit Bot 2015-09-01 11:45:24 PDT 
All reviewed patches have been landed.  Closing bug.