Bug 148678 – Web Inspector: visual style editor fields should restore previous value when invalid inputs are entered

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Web Inspector

[Blaze Burg]

This is a followup bug to https://bugs.webkit.org/show_bug.cgi?id=148580.

We shouldn't be storing the input state in the DOM, it should be kept in the widget class separately and synced when valid values are committed.

[Radar WebKit Bug Importer]

<rdar://problem/22518919>

[Devin Rousso]

(In reply to comment #0)
> We shouldn't be storing the input state in the DOM, it should be kept in the
> widget class separately and synced when valid values are committed.

I agree with you that we should have member variables for the current value, but I am not sure about "restore previous value when invalid inputs are entered".  What exactly do you mean by that?  Would it be something like "display: foo;"?  If so, I don't think we should just revert to the previous value because that would remove any support for other browsers/custom css.  Maybe something like a warning saying "this won't work"...

[Devin Rousso]

The Visual styles sidebar was removed in r236298 <https://webkit.org/b/189807>.