RESOLVED FIXED 148677
Web Inspector: add pixel area column to layout timeline view 
https://bugs.webkit.org/show_bug.cgi?id=148677
Summary Web Inspector: add pixel area column to layout timeline view
Blaze Burg
Reported 2015-09-01 08:33:03 PDT
Showing the dimensions is nice but the area is more important from a performance impact perspective. We could even highlight paints above some threshold, like >50% of the viewport or something. But just having the data (again) would be nice.
Attachments
[Patch] Proposed Fix (3.57 KB, patch)
2016-06-19 17:32 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (2.19 KB, patch)
2016-06-30 15:00 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-01 08:33:33 PDT
<rdar://problem/22518762>
Timothy Hatcher
Comment 2 2015-09-01 09:54:23 PDT
We had area. I can't remember why we removed it.
Matt Baker
Comment 3 2016-06-19 17:32:17 PDT
Created attachment 281627 [details] [Patch] Proposed Fix
Blaze Burg
Comment 4 2016-06-20 10:18:19 PDT
Comment on attachment 281627 [details] [Patch] Proposed Fix r=me Where is the px^2 string used?
Joseph Pecoraro
Comment 5 2016-06-20 10:49:41 PDT
Comment on attachment 281627 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281627&action=review > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:52 > + area: this._record.width * this._record.height, > width: this._record.width, > height: this._record.height, > area: this._record.width * this._record.height, Area is already here on line 52.
Blaze Burg
Comment 6 2016-06-30 14:35:41 PDT
Comment on attachment 281627 [details] [Patch] Proposed Fix Clearing review queue. Please remove duplicate 'area'.
Matt Baker
Comment 7 2016-06-30 15:00:17 PDT
Created attachment 282473 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 8 2016-06-30 15:29:57 PDT
Comment on attachment 282473 [details] [Patch] Proposed Fix Clearing flags on attachment: 282473 Committed r202713: <http://trac.webkit.org/changeset/202713>
WebKit Commit Bot
Comment 9 2016-06-30 15:30:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.