Bug 148662 - [ES6] Tail call fast path should efficiently reuse the frame's stack space
Summary: [ES6] Tail call fast path should efficiently reuse the frame's stack space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 148334 148335 148337 148448 148661
Blocks: 148663
  Show dependency treegraph
 
Reported: 2015-08-31 17:51 PDT by Basile Clement
Modified: 2015-09-18 16:51 PDT (History)
2 users (show)

See Also:


Attachments
Patch (122.12 KB, patch)
2015-09-04 15:00 PDT, Basile Clement
no flags Details | Formatted Diff | Diff
Rebased patch (122.93 KB, patch)
2015-09-16 18:06 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Patch with fix for 32 bit debug build (122.95 KB, patch)
2015-09-16 20:35 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Patch with speculative build fixes (125.78 KB, patch)
2015-09-16 22:31 PDT, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff
Patch for Landing (and EWS testing) (133.07 KB, patch)
2015-09-18 15:51 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-08-31 17:51:29 PDT
...
Comment 1 Basile Clement 2015-09-04 15:00:28 PDT
Created attachment 260626 [details]
Patch
Comment 2 Michael Saboff 2015-09-16 18:06:45 PDT
Created attachment 261344 [details]
Rebased patch
Comment 3 WebKit Commit Bot 2015-09-16 18:09:47 PDT
Attachment 261344 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:604:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:627:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:648:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2015-09-16 20:35:49 PDT
Created attachment 261360 [details]
Patch with fix for 32 bit debug build
Comment 5 WebKit Commit Bot 2015-09-16 20:38:06 PDT
Attachment 261360 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:604:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:627:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:648:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Michael Saboff 2015-09-16 22:31:28 PDT
Created attachment 261368 [details]
Patch with speculative build fixes
Comment 7 WebKit Commit Bot 2015-09-16 22:33:04 PDT
Attachment 261368 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:604:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:627:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:648:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Geoffrey Garen 2015-09-18 11:13:29 PDT
Comment on attachment 261368 [details]
Patch with speculative build fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=261368&action=review

r=me

> Source/JavaScriptCore/jit/CallFrameShuffler.h:45
> +class CachedRecovery {

Please move this class to its own file.
Comment 9 Michael Saboff 2015-09-18 15:51:25 PDT
Created attachment 261533 [details]
Patch for Landing (and EWS testing)
Comment 10 WebKit Commit Bot 2015-09-18 15:53:11 PDT
Attachment 261533 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/CachedRecovery.cpp:34:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:507:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:530:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:551:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Michael Saboff 2015-09-18 16:51:54 PDT
Committed r189999: <http://trac.webkit.org/changeset/189999>