Bug 148660 - [Cocoa] Testing: Allow overriding the system language for language-dependent tests
Summary: [Cocoa] Testing: Allow overriding the system language for language-dependent ...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-31 17:19 PDT by Myles C. Maxfield
Modified: 2015-08-31 23:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2015-08-31 17:19 PDT, Myles C. Maxfield 		mmaxfield: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-31 17:19:06 PDT 
[Cocoa] Testing: Allow overriding the system language for language-dependent tests
Comment 1 Myles C. Maxfield 2015-08-31 17:19:27 PDT 
Created attachment 260340 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-31 17:38:53 PDT 
Comment on attachment 260340 [details]
Patch

This should be done inside WebKitTestRunner
Comment 3 Alexey Proskuryakov 2015-08-31 22:05:10 PDT 
Comment on attachment 260340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260340&action=review

> Tools/Scripts/webkitpy/port/base.py:532
> +            first_line = f.readline()

We probably need to allow having the metadata on the second line, because nothing can precede XML declaration.
Comment 4 Myles C. Maxfield 2015-08-31 23:16:50 PDT 
Superseded by https://bugs.webkit.org/show_bug.cgi?id=148671