RESOLVED INVALID148660
[Cocoa] Testing: Allow overriding the system language for language-dependent tests 
https://bugs.webkit.org/show_bug.cgi?id=148660
Summary [Cocoa] Testing: Allow overriding the system language for language-dependent ...
Myles C. Maxfield
Reported 2015-08-31 17:19:06 PDT
[Cocoa] Testing: Allow overriding the system language for language-dependent tests
Attachments
Patch (4.41 KB, patch)
2015-08-31 17:19 PDT, Myles C. Maxfield 		mmaxfield: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-08-31 17:19:27 PDT
Created attachment 260340 [details] Patch
Myles C. Maxfield
Comment 2 2015-08-31 17:38:53 PDT
Comment on attachment 260340 [details] Patch This should be done inside WebKitTestRunner
Alexey Proskuryakov
Comment 3 2015-08-31 22:05:10 PDT
Comment on attachment 260340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260340&action=review > Tools/Scripts/webkitpy/port/base.py:532 > + first_line = f.readline() We probably need to allow having the metadata on the second line, because nothing can precede XML declaration.
Myles C. Maxfield
Comment 4 2015-08-31 23:16:50 PDT
Superseded by https://bugs.webkit.org/show_bug.cgi?id=148671
Note You need to log in before you can comment on or make changes to this bug.