Range API is currently throwing a RangeException for some type of errors instead of regular DOM exceptions. The error code is also not the one that is expected according to the latest specification. Firefox and Chrome match the specification and do not have a RangeException type.
Created attachment 260324 [details] Patch
Comment on attachment 260324 [details] Patch Attachment 260324 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/127693 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html http/tests/w3c/dom/historical.html js/dom/global-constructors-attributes.html
Created attachment 260325 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 260324 [details] Patch Attachment 260324 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/127700 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/w3c/dom/historical.html js/dom/global-constructors-attributes.html
Created attachment 260326 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 260328 [details] Patch
Looks like global-constructors-attributes-expected.txt needs to be updated?
(In reply to comment #7) > Looks like global-constructors-attributes-expected.txt needs to be updated? Yes, I only ran the fast/ folder locally :P The latest iteration should take care of it, I was waiting for EWS to confirm before I set the review flag.
(In reply to comment #8) > (In reply to comment #7) > > Looks like global-constructors-attributes-expected.txt needs to be updated? > > Yes, I only ran the fast/ folder locally :P The latest iteration should take > care of it, I was waiting for EWS to confirm before I set the review flag. Okay. Are you gonna set r? later?
Comment on attachment 260328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260328&action=review > Source/WebCore/dom/RangeException.cpp:-2 > - * Copyright (C) 2011 Google Inc. All rights reserved. It's funny how this is Google-copyrighted. We probably added these exceptions back in 2011 to match the spec then LOL.
Comment on attachment 260328 [details] Patch Attachment 260328 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/127822 New failing tests: js/dom/global-constructors-attributes.html
Created attachment 260337 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 260328 [details] Patch Attachment 260328 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/127835 New failing tests: js/dom/global-constructors-attributes.html
Created attachment 260339 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 260343 [details] Patch
Comment on attachment 260343 [details] Patch Clearing flags on attachment: 260343 Committed r189202: <http://trac.webkit.org/changeset/189202>
All reviewed patches have been landed. Closing bug.
This broke windows build (and no, I don't know why EWS would build, but regular bots wouldn't). DerivedSources.cpp c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\obj32\webcore\derivedsources\JSRangeException.h(25): fatal error C1083: Cannot open include file: 'RangeException.h': No such file or directory [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
(In reply to comment #18) > This broke windows build (and no, I don't know why EWS would build, but > regular bots wouldn't). > > DerivedSources.cpp > c:\cygwin\home\buildbot\slave\win- > release\build\webkitbuild\release\obj32\webcore\derivedsources\JSRangeExcepti > on.h(25): fatal error C1083: Cannot open include file: 'RangeException.h': > No such file or directory > [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore. > vcxproj\WebCore.vcxproj] Ok, I will look into this now. Thanks.
(In reply to comment #19) > (In reply to comment #18) > > This broke windows build (and no, I don't know why EWS would build, but > > regular bots wouldn't). > > > > DerivedSources.cpp > > c:\cygwin\home\buildbot\slave\win- > > release\build\webkitbuild\release\obj32\webcore\derivedsources\JSRangeExcepti > > on.h(25): fatal error C1083: Cannot open include file: 'RangeException.h': > > No such file or directory > > [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore. > > vcxproj\WebCore.vcxproj] > > Ok, I will look into this now. Thanks. Actually, if I grep for RangeException in Source/, there is nothing. Also JSRangeException.h is not supposed to exist anymore. I think the bot may simply need a clean build.
(In reply to comment #20) > (In reply to comment #19) > > (In reply to comment #18) > > > This broke windows build (and no, I don't know why EWS would build, but > > > regular bots wouldn't). > > > > > > DerivedSources.cpp > > > c:\cygwin\home\buildbot\slave\win- > > > release\build\webkitbuild\release\obj32\webcore\derivedsources\JSRangeExcepti > > > on.h(25): fatal error C1083: Cannot open include file: 'RangeException.h': > > > No such file or directory > > > [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore. > > > vcxproj\WebCore.vcxproj] > > > > Ok, I will look into this now. Thanks. > > Actually, if I grep for RangeException in Source/, there is nothing. Also > JSRangeException.h is not supposed to exist anymore. I think the bot may > simply need a clean build. I triggered clean builds on the Windows bots to confirm.
rdar://problem/22544508