148635 – Watchdog timer callback should release the lock before deref’ing the Watchdog

Bug 148635 - Watchdog timer callback should release the lock before deref’ing the Watchdog

Summary: Watchdog timer callback should release the lock before deref’ing the Watchdog

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	WebKit Local Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Mark Lam

URL:
Keywords:	InRadar

Depends on:
Blocks:

Attachments
the fix. (1.46 KB, patch) 2015-08-31 09:57 PDT, Mark Lam	no flags	Details \| Formatted Diff \| Diff
fix 2: fixed ChangeLog comment (1.45 KB, patch) 2015-08-31 10:00 PDT, Mark Lam	fpizlo: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Lam 2015-08-31 09:49:32 PDT

The deref’ing of the watchdog may free it.  The lock may not be available to be unlocked after the deref.

Comment 1 Mark Lam 2015-08-31 09:54:36 PDT

<rdar://problem/22495785>

Comment 2 Mark Lam 2015-08-31 09:57:52 PDT

Created attachment 260290 [details]
the fix.

Comment 3 Mark Lam 2015-08-31 10:00:46 PDT

Created attachment 260291 [details]
fix 2: fixed ChangeLog comment

Comment 4 Mark Lam 2015-08-31 10:05:14 PDT

Thanks for the review.  Landed in r189172: <http://trac.webkit.org/r189172>.