Bug 148631 - [Cairo][WebGL] Upload the accelerated canvas as a texture by copying via GPU directly
Summary: [Cairo][WebGL] Upload the accelerated canvas as a texture by copying via GPU ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinyoung Hur
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-31 08:06 PDT by Jinyoung Hur
Modified: 2015-09-01 10:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.44 KB, patch)
2015-08-31 08:18 PDT, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2015-08-31 09:06 PDT, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2015-08-31 09:11 PDT, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinyoung Hur 2015-08-31 08:06:01 PDT 
[Cairo] Upload the accelerated canvas as a texture by GPU to GPU copy if possible
Comment 1 Jinyoung Hur 2015-08-31 08:18:35 PDT 
Created attachment 260282 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-31 08:21:06 PDT 
Attachment 260282 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jinyoung Hur 2015-08-31 09:06:54 PDT 
Created attachment 260285 [details]
Patch
Comment 4 Jinyoung Hur 2015-08-31 09:11:21 PDT 
Created attachment 260286 [details]
Patch
Comment 5 Jinyoung Hur 2015-08-31 15:42:03 PDT 
When an accelerated canvas needs to be uploaded as a gl texture, it would be better to copy it to texture directly via GPU using glCopyTexImage2D.
Comment 6 WebKit Commit Bot 2015-09-01 10:40:22 PDT 
Comment on attachment 260286 [details]
Patch

Clearing flags on attachment: 260286

Committed r189216: <http://trac.webkit.org/changeset/189216>
Comment 7 WebKit Commit Bot 2015-09-01 10:40:26 PDT 
All reviewed patches have been landed.  Closing bug.