Bug 148629 - Incorrect cursor movement for U+26F9, U+1F3CB with variations
Summary: Incorrect cursor movement for U+26F9, U+1F3CB with variations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified OS X 10.11
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-31 06:09 PDT by Enrica Casucci
Modified: 2015-08-31 08:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (18.52 KB, patch)
2015-08-31 06:32 PDT, Enrica Casucci 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (553.93 KB, application/zip)
2015-08-31 07:04 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (614.53 KB, application/zip)
2015-08-31 07:09 PDT, Build Bot 		no flags Details
Patch2 (11.81 KB, patch)
2015-08-31 07:27 PDT, Enrica Casucci 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-08-31 06:09:16 PDT 
rdar://problem/22492366
Comment 1 Enrica Casucci 2015-08-31 06:32:19 PDT 
Created attachment 260277 [details]
Patch
Comment 2 Build Bot 2015-08-31 07:04:50 PDT 
Comment on attachment 260277 [details]
Patch

Attachment 260277 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/126263

New failing tests:
editing/deleting/delete-emoji.html
Comment 3 Build Bot 2015-08-31 07:04:55 PDT 
Created attachment 260278 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-08-31 07:09:38 PDT 
Comment on attachment 260277 [details]
Patch

Attachment 260277 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/126268

New failing tests:
editing/deleting/delete-emoji.html
Comment 5 Build Bot 2015-08-31 07:09:44 PDT 
Created attachment 260279 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Enrica Casucci 2015-08-31 07:27:43 PDT 
Created attachment 260280 [details]
Patch2
Comment 7 Ryosuke Niwa 2015-08-31 07:55:11 PDT 
Comment on attachment 260280 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=260280&action=review

> Source/WebCore/platform/text/TextBreakIterator.cpp:-450
>      "$EmojiForSeqs = [\\u2764 \\U0001F441 \\U0001F466-\\U0001F469 \\U0001F48B \\U0001F5E8];"
> -    "$EmojiForMods = [\\u261D \\u270A-\\u270D \\U0001F385 \\U0001F3C3-\\U0001F3C4 \\U0001F3C7 \\U0001F3CA \\U0001F442-\\U0001F443 \\U0001F446-\\U0001F450 \\U0001F466-\\U0001F469 \\U0001F46E-\\U0001F478 \\U0001F47C \\U0001F481-\\U0001F483 \\U0001F485-\\U0001F487 \\U0001F4AA \\U0001F590 \\U0001F595 \\U0001F596 \\U0001F645-\\U0001F647 \\U0001F64B-\\U0001F64F \\U0001F6A3 \\U0001F6B4-\\U0001F6B6 \\U0001F6C0 \\U0001F918] ;" // Emoji that take Fitzpatrick modifiers

Obviously not in this patch but is there a way to avoid duplicating the table here?
Comment 8 Enrica Casucci 2015-08-31 08:08:21 PDT 
(In reply to comment #7)
> Comment on attachment 260280 [details]
> Patch2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260280&action=review
> 
> > Source/WebCore/platform/text/TextBreakIterator.cpp:-450
> >      "$EmojiForSeqs = [\\u2764 \\U0001F441 \\U0001F466-\\U0001F469 \\U0001F48B \\U0001F5E8];"
> > -    "$EmojiForMods = [\\u261D \\u270A-\\u270D \\U0001F385 \\U0001F3C3-\\U0001F3C4 \\U0001F3C7 \\U0001F3CA \\U0001F442-\\U0001F443 \\U0001F446-\\U0001F450 \\U0001F466-\\U0001F469 \\U0001F46E-\\U0001F478 \\U0001F47C \\U0001F481-\\U0001F483 \\U0001F485-\\U0001F487 \\U0001F4AA \\U0001F590 \\U0001F595 \\U0001F596 \\U0001F645-\\U0001F647 \\U0001F64B-\\U0001F64F \\U0001F6A3 \\U0001F6B4-\\U0001F6B6 \\U0001F6C0 \\U0001F918] ;" // Emoji that take Fitzpatrick modifiers
> 
> Obviously not in this patch but is there a way to avoid duplicating the
> table here?

I don't think so, but I don't know much about how ICU rules work, Peter makes the changes.
Comment 9 Enrica Casucci 2015-08-31 08:42:00 PDT 
Committed revision 189167.