[GTK] [Stable] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer
Created attachment 260212 [details]
Comment on attachment 260212 [details]
Add a stub for the InstallMissingMediaPluginsPermissionRequest class for the case when video is disabled or not using GStreamer. It's OK that this class does nothing, because the associated C API contains an assert_not_reached if video is disabled. We just need to define the symbol so that the function signature will compile.
I'll add this to the proposed merges for 2.9.92.
FYI: we use [Stable] to indicate a patch that should not be committed to master (so it should not be used in combination with commit-queue).
OK, thanks for explaining. I meant this patch to be for both master and stable.
My confusion arose because the instructions on http://trac.webkit.org/wiki/WebKitGTK/2.10.x say to use "[GTK] [Stable]" so I'll add a note there explaining what you just told me.
Since this is a build fix, any committer can approve it, so if you attach a new patch with the "Reviewed by NOBODOY" line replaced with "Unreviewed" and request only commit-queue? but not review?, I will grant that.
Created attachment 264118 [details]
Thank you here as well!
Comment on attachment 264118 [details]
Clearing flags on attachment: 264118
Committed r191618: <http://trac.webkit.org/changeset/191618>
All reviewed patches have been landed. Closing bug.