Bug 148595 - Refactor the JIT printer out of the AbstractMacroAssembler into MacroAssemblerPrinter.
Summary: Refactor the JIT printer out of the AbstractMacroAssembler into MacroAssemble...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-28 15:49 PDT by Mark Lam
Modified: 2015-08-28 15:59 PDT (History)
0 users

See Also:

Attachments
the fix. (41.13 KB, patch)
2015-08-28 15:51 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
fix 2: remove those accidental newlines in VC project files. (40.79 KB, patch)
2015-08-28 15:54 PDT, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-08-28 15:49:35 PDT 
Why do this?
1. MacroAssembler::print() code (except for the prototype) need no longer be parsed when compiling C++ files that don't need it.
2. Adding support for more printable types to MacroAssemblerPrinter::PrintArg triggers recompilation of less files.
3. The printing code is for most the part common between all target platforms and was previously duplicated by cut-and-paste to all the varieties of MacroAssemblers that support the MASM_PROBE mechanism.  Now, there is only one copy in MacroAssemblerPrinter.
Comment 1 Mark Lam 2015-08-28 15:51:42 PDT 
Created attachment 260187 [details]
the fix.
Comment 2 Mark Lam 2015-08-28 15:54:06 PDT 
Created attachment 260188 [details]
fix 2: remove those accidental newlines in VC project files.
Comment 3 Geoffrey Garen 2015-08-28 15:55:22 PDT 
Comment on attachment 260188 [details]
fix 2: remove those accidental newlines in VC project files.

r=me
Comment 4 Mark Lam 2015-08-28 15:59:46 PDT 
Thanks for the review.  Landed in r189130: <http://trac.webkit.org/r189130>.