RESOLVED FIXED 148593
[Mac] Restructure WebMediaSessionManager for testing 
https://bugs.webkit.org/show_bug.cgi?id=148593
Summary [Mac] Restructure WebMediaSessionManager for testing
Eric Carlson
Reported 2015-08-28 15:19:39 PDT
Restructure so it is possible to use a Mock target picker.
Attachments
Proposed patch. (10.12 KB, patch)
2015-08-28 15:55 PDT, Eric Carlson 		jer.noble: review+
DetailsFormatted DiffDiff
Patch for landing. (10.08 KB, patch)
2015-08-28 16:14 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-28 15:20:20 PDT
<rdar://problem/22483489>
Eric Carlson
Comment 2 2015-08-28 15:55:20 PDT
Created attachment 260189 [details] Proposed patch.
Jer Noble
Comment 3 2015-08-28 16:04:44 PDT
Comment on attachment 260189 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=260189&action=review r=me, with nit. > Source/WebCore/Modules/mediasession/WebMediaSessionManager.h:48 > + WEBCORE_EXPORT static WebMediaSessionManager& singleton(); nit: singleton() is a weird nomenclature. I mean, in other places we use shared(), which implies that it's singleton. But this object is specifically not a singleton! Because it's overridable, it's a ... dual... ton. Or something.
Eric Carlson
Comment 4 2015-08-28 16:14:27 PDT
Created attachment 260193 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2015-08-28 17:15:13 PDT
Comment on attachment 260193 [details] Patch for landing. Clearing flags on attachment: 260193 Committed r189135: <http://trac.webkit.org/changeset/189135>
Csaba Osztrogonác
Comment 6 2015-09-04 03:56:09 PDT
The patch already landed, let's close the bug.
Note You need to log in before you can comment on or make changes to this bug.