Bug 148593 - [Mac] Restructure WebMediaSessionManager for testing
Summary: [Mac] Restructure WebMediaSessionManager for testing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2015-08-28 15:19 PDT by Eric Carlson
Modified: 2015-09-04 03:56 PDT (History)
4 users (show)

See Also:

Proposed patch. (10.12 KB, patch)
2015-08-28 15:55 PDT, Eric Carlson
jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (10.08 KB, patch)
2015-08-28 16:14 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-08-28 15:19:39 PDT
Restructure so it is possible to use a Mock target picker.
Comment 1 Radar WebKit Bug Importer 2015-08-28 15:20:20 PDT
Comment 2 Eric Carlson 2015-08-28 15:55:20 PDT
Created attachment 260189 [details]
Proposed patch.
Comment 3 Jer Noble 2015-08-28 16:04:44 PDT
Comment on attachment 260189 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=260189&action=review

r=me, with nit.

> Source/WebCore/Modules/mediasession/WebMediaSessionManager.h:48
> +    WEBCORE_EXPORT static WebMediaSessionManager& singleton();

nit: singleton() is a weird nomenclature.  I mean, in other places we use shared(), which implies that it's singleton.  But this object is specifically not a singleton! Because it's overridable, it's a ... dual... ton. Or something.
Comment 4 Eric Carlson 2015-08-28 16:14:27 PDT
Created attachment 260193 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2015-08-28 17:15:13 PDT
Comment on attachment 260193 [details]
Patch for landing.

Clearing flags on attachment: 260193

Committed r189135: <http://trac.webkit.org/changeset/189135>
Comment 6 Csaba Osztrogonác 2015-09-04 03:56:09 PDT
The patch already landed, let's close the bug.