RESOLVED FIXED 148570
[GTK] Simplify the internal API to create a WebView 
https://bugs.webkit.org/show_bug.cgi?id=148570
Summary [GTK] Simplify the internal API to create a WebView
Carlos Garcia Campos
Reported 2015-08-28 03:37:42 PDT
Now that all the information required to create a WebView is in API::PageConfiguration, we can simplify the internal API to receive only the configuration instead of receiving a long list of parameters that we use to build a new API::PageConfiguration.
Attachments
Patch (13.07 KB, patch)
2015-08-28 03:40 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-08-28 03:40:44 PDT
Created attachment 260145 [details] Patch
WebKit Commit Bot
Comment 2 2015-08-28 03:41:23 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2015-08-28 03:55:23 PDT
Comment on attachment 260145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260145&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1050 > + Ref<API::PageConfiguration> copiedConfiguration = configuration.copy(); > + webkitWebViewBaseCreateWebPage(webkitWebViewBase, WTF::move(copiedConfiguration)); Can be just: webkitWebViewBaseCreateWebPage(webkitWebViewBase, configuration.copy());
Carlos Garcia Campos
Comment 4 2015-08-28 04:16:32 PDT
Committed r189094: <http://trac.webkit.org/changeset/189094>
Note You need to log in before you can comment on or make changes to this bug.