Bug 148570 - [GTK] Simplify the internal API to create a WebView
Summary: [GTK] Simplify the internal API to create a WebView
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2015-08-28 03:37 PDT by Carlos Garcia Campos
Modified: 2015-08-28 04:16 PDT (History)
6 users (show)

See Also:

Patch (13.07 KB, patch)
2015-08-28 03:40 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-08-28 03:37:42 PDT
Now that all the information required to create a WebView is in API::PageConfiguration, we can simplify the internal API to receive only the configuration instead of receiving a long list of parameters that we use to build a new API::PageConfiguration.
Comment 1 Carlos Garcia Campos 2015-08-28 03:40:44 PDT
Created attachment 260145 [details]
Comment 2 WebKit Commit Bot 2015-08-28 03:41:23 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2015-08-28 03:55:23 PDT
Comment on attachment 260145 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=260145&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1050
> +    Ref<API::PageConfiguration> copiedConfiguration = configuration.copy();
> +    webkitWebViewBaseCreateWebPage(webkitWebViewBase, WTF::move(copiedConfiguration));

Can be just:

    webkitWebViewBaseCreateWebPage(webkitWebViewBase, configuration.copy());
Comment 4 Carlos Garcia Campos 2015-08-28 04:16:32 PDT
Committed r189094: <http://trac.webkit.org/changeset/189094>