Bug 148568 - Add navigation gesture callbacks to WKPageNavigationClient
Summary: Add navigation gesture callbacks to WKPageNavigationClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-28 01:47 PDT by Tim Horton
Modified: 2015-08-30 04:09 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.07 KB, patch)
2015-08-28 01:47 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-08-28 01:47:38 PDT
Add navigation gesture callbacks to WKPageNavigationClient
Comment 1 Tim Horton 2015-08-28 01:47:54 PDT
Created attachment 260138 [details]
Patch
Comment 2 Tim Horton 2015-08-28 01:48:19 PDT
<rdar://problem/22371346>
Comment 3 Anders Carlsson 2015-08-28 10:41:16 PDT
Comment on attachment 260138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260138&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:98
> +    typedef std::tuple<WKPageNavigationClientV0, WKPageNavigationClientV1> Versions;

I don't think we need a new version of the struct yet - we haven't shipped anything that relies on it.
Comment 4 Tim Horton 2015-08-28 11:38:55 PDT
http://trac.webkit.org/changeset/189109