Bug 148551 - Minor fixes in reportUnexpectedSyscall
Summary: Minor fixes in reportUnexpectedSyscall
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-27 18:00 PDT by Michael Catanzaro
Modified: 2015-08-28 07:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2015-08-27 18:04 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-08-27 18:00:26 PDT 
There is an off-by-one in the static assert.

Also, an unsigned long long is passed in, but the parameter is an int. Then it's passed to writeUnsignedInt, which takes an unsigned int. Let's use unsigned int instead. (The value is a syscall number, so it's safe to truncate regardless -- it never be anywhere near as large as an int -- so this is just a matter of style.)
Comment 1 Michael Catanzaro 2015-08-27 18:04:12 PDT 
Created attachment 260103 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-28 07:23:15 PDT 
Comment on attachment 260103 [details]
Patch

Clearing flags on attachment: 260103

Committed r189097: <http://trac.webkit.org/changeset/189097>
Comment 3 WebKit Commit Bot 2015-08-28 07:23:21 PDT 
All reviewed patches have been landed.  Closing bug.