Bug 148549 – Web Inspector: Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 260101 [details]
[Image] Barely visible Layout slice

* SUMMARY
Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart. A minimum segment percentage should be established to avoid creating sub-pixel chart segments.

[Radar WebKit Bug Importer]

<rdar://problem/22467802>

[Matt Baker]

Created attachment 260250 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 260251 [details]
[Image] New chart behavior

Debugging data shown in legend items not included in patch.

[Timothy Hatcher]

Comment on attachment 260250 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=260250&action=review

> Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js:322
> +        // Balance item values so that all non-zero chart segments are visible.
> +        const minimumDisplayValue = this._total * 0.02;

Why not 1%? 2% seems a little big for a minimum to me.

[Matt Baker]

Created attachment 260298 [details]
[Image] Minimum slice sizes: 1% and 1.5%

Layout data point (less than 1% of total selection) drawn at 1% and 1.5%.

[Matt Baker]

(In reply to comment #4)
> Comment on attachment 260250 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260250&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js:322
> > +        // Balance item values so that all non-zero chart segments are visible.
> > +        const minimumDisplayValue = this._total * 0.02;
> 
> Why not 1%? 2% seems a little big for a minimum to me.

I think 1% is difficult to see, especially with the light stroke around pie slices. The difference between 1, 1.5. and 2% is subtle, but I think it looks better at 1.5 or 2. See previous attachment.

[Matt Baker]

Created attachment 260303 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 260303 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 260303

Committed r189183: <http://trac.webkit.org/changeset/189183>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.