Bug 148539 - [Win CMake] Fix incremental build after r188673
Summary: [Win CMake] Fix incremental build after r188673
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-27 14:19 PDT by Alex Christensen
Modified: 2015-08-27 14:32 PDT (History)
0 users

See Also:

Attachments
Patch (7.23 KB, patch)
2015-08-27 14:24 PDT, Alex Christensen 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-08-27 14:19:31 PDT 
Using CMake's file(COPY ...) copies files only when CMake is run, which is only when a CMakeLists.txt or PlatformWin.cmake is touched.  When a header is changed but no files are added or removed, it breaks the incremental build.  Using xcopy as a build step solves this.
Comment 1 Alex Christensen 2015-08-27 14:24:20 PDT 
Created attachment 260088 [details]
Patch
Comment 2 Brent Fulgham 2015-08-27 14:29:10 PDT 
Comment on attachment 260088 [details]
Patch

r=me
Comment 3 Alex Christensen 2015-08-27 14:32:05 PDT 
r189055