148536 – [JSC][x86] Improve the compare functions when comparing with zero

Benjamin Poulain

Reported 2015-08-27 13:57:26 PDT

[JSC][x86] Improve the compare functions when comparing with zero

Benjamin Poulain

Comment 1 2015-08-27 14:00:04 PDT

Created attachment 260084 [details] Patch

Benjamin Poulain

Comment 2 2015-08-27 14:01:08 PDT

Conf#1 Conf#2 SunSpider: 3d-cube 4.2213+-0.2460 ? 4.2564+-0.3320 ? 3d-morph 4.8024+-0.1969 4.7922+-0.1175 3d-raytrace 4.6953+-0.1381 4.6162+-0.0356 might be 1.0171x faster access-binary-trees 1.8320+-0.2021 ? 1.9376+-0.2166 ? might be 1.0576x slower access-fannkuch 4.9107+-0.1545 4.8625+-0.1920 access-nbody 2.2789+-0.1434 2.2022+-0.0178 might be 1.0348x faster access-nsieve 2.8198+-0.1969 2.8052+-0.1251 bitops-3bit-bits-in-byte 1.3192+-0.0120 1.3162+-0.0124 bitops-bits-in-byte 3.2469+-0.4939 ? 3.3499+-0.2814 ? might be 1.0317x slower bitops-bitwise-and 1.8206+-0.0106 1.8165+-0.0048 bitops-nsieve-bits 2.7867+-0.1424 2.7405+-0.1321 might be 1.0169x faster controlflow-recursive 1.9372+-0.2231 1.8702+-0.1369 might be 1.0358x faster crypto-aes 3.5107+-0.1666 3.4259+-0.2182 might be 1.0248x faster crypto-md5 2.2357+-0.2001 2.1530+-0.0054 might be 1.0384x faster crypto-sha1 2.1493+-0.1540 ? 2.1641+-0.1829 ? date-format-tofte 6.2277+-0.4804 6.1926+-0.1964 date-format-xparb 4.4306+-0.0877 ? 4.4822+-0.2057 ? might be 1.0117x slower math-cordic 2.5318+-0.0585 2.5111+-0.0119 math-partial-sums 4.7090+-0.1477 ? 4.7645+-0.1647 ? might be 1.0118x slower math-spectral-norm 1.6904+-0.1276 1.6323+-0.0375 might be 1.0356x faster regexp-dna 5.8918+-0.1034 ? 6.1472+-0.5873 ? might be 1.0434x slower string-base64 3.8230+-0.0964 ? 3.8643+-0.1292 ? might be 1.0108x slower string-fasta 5.5665+-0.3484 5.5652+-0.3225 string-tagcloud 7.7008+-0.2278 7.5397+-0.1190 might be 1.0214x faster string-unpack-code 16.9604+-0.4780 ? 17.1899+-0.0944 ? might be 1.0135x slower string-validate-input 4.4407+-0.5717 4.1559+-0.1212 might be 1.0685x faster <arithmetic> 4.1746+-0.0246 4.1674+-0.0359 might be 1.0017x faster Conf#1 Conf#2 LongSpider: 3d-cube 754.6711+-12.5434 ? 755.6470+-12.4365 ? 3d-morph 1444.2814+-5.9676 1442.8652+-1.9906 3d-raytrace 574.6968+-8.2056 573.0945+-7.7619 access-binary-trees 870.5255+-21.6902 864.3260+-10.6654 access-fannkuch 261.5862+-2.6669 ? 264.0532+-7.5651 ? access-nbody 489.6934+-0.9819 488.4647+-0.6743 access-nsieve 475.6008+-6.9662 472.6745+-4.2409 bitops-3bit-bits-in-byte 38.0875+-5.4850 36.1080+-0.2300 might be 1.0548x faster bitops-bits-in-byte 72.3462+-1.3836 71.8598+-1.1626 bitops-nsieve-bits 371.1223+-1.4586 ? 372.3516+-8.2256 ? controlflow-recursive 413.2025+-0.4787 ^ 396.7720+-0.7867 ^ definitely 1.0414x faster crypto-aes 557.9525+-13.9101 555.4147+-7.3829 crypto-md5 481.1819+-9.8302 474.9514+-15.0536 might be 1.0131x faster crypto-sha1 613.7358+-18.0632 602.6440+-13.5144 might be 1.0184x faster date-format-tofte 478.7672+-19.2404 478.1426+-14.7614 date-format-xparb 712.8673+-3.1166 ? 716.1057+-5.2541 ? hash-map 146.7275+-7.1119 ? 147.3948+-5.6275 ? math-cordic 465.0251+-1.9857 464.3991+-0.9345 math-partial-sums 452.1161+-1.4920 ^ 448.9893+-0.6214 ^ definitely 1.0070x faster math-spectral-norm 531.6671+-7.6095 529.7056+-1.7609 string-base64 343.8403+-5.8541 ? 347.0363+-14.8927 ? string-fasta 361.2495+-13.6049 358.0641+-3.3399 string-tagcloud 172.3652+-1.7244 ? 172.4335+-1.6149 ? <geometric> 384.0550+-3.7706 381.6797+-1.9742 might be 1.0062x faster Conf#1 Conf#2 V8Spider: crypto 45.9605+-2.3690 ? 46.2665+-1.5651 ? deltablue 83.3637+-3.3125 ? 85.1381+-7.7231 ? might be 1.0213x slower earley-boyer 38.9952+-1.4017 ? 39.4352+-2.4084 ? might be 1.0113x slower raytrace 31.8197+-1.9221 ? 32.3165+-1.2748 ? might be 1.0156x slower regexp 59.1339+-0.5916 58.4431+-0.5911 might be 1.0118x faster richards 60.9073+-0.6104 ? 61.2653+-1.0585 ? splay 36.3414+-2.6382 35.3319+-2.8874 might be 1.0286x faster <geometric> 48.3862+-0.3490 ? 48.5264+-1.5105 ? might be 1.0029x slower Conf#1 Conf#2 Octane: encrypt 0.16388+-0.00018 0.16383+-0.00052 decrypt 3.14602+-0.00853 3.07761+-0.23929 might be 1.0222x faster deltablue x2 0.16095+-0.03138 0.15251+-0.00164 might be 1.0553x faster earley 0.29638+-0.00777 0.29523+-0.00233 boyer 4.29101+-0.11272 4.23752+-0.01450 might be 1.0126x faster navier-stokes x2 4.67557+-0.02338 4.67323+-0.01492 raytrace x2 1.04512+-0.06150 1.04432+-0.06600 richards x2 0.10460+-0.00303 ? 0.10511+-0.00150 ? splay x2 0.38248+-0.00523 ? 0.38278+-0.00677 ? regexp x2 23.77998+-1.03019 ? 23.90707+-1.07046 ? pdfjs x2 35.86876+-0.18873 ? 36.44297+-1.10512 ? might be 1.0160x slower mandreel x2 42.66160+-1.39515 42.26010+-1.67300 gbemu x2 31.26094+-0.53696 ? 31.74893+-2.55150 ? might be 1.0156x slower closure 0.52629+-0.00196 ? 0.52710+-0.00065 ? jquery 6.65788+-0.04361 ? 6.65893+-0.01430 ? box2d x2 9.32098+-0.06880 9.21554+-0.11059 might be 1.0114x faster zlib x2 379.72457+-12.36642 ? 383.02374+-8.72027 ? typescript x2 611.28174+-6.90927 ? 616.58997+-12.83180 ? <geometric> 5.46769+-0.10800 5.45612+-0.04516 might be 1.0021x faster Conf#1 Conf#2 Kraken: ai-astar 209.714+-4.802 208.385+-2.292 audio-beat-detection 47.519+-0.539 ? 47.908+-0.476 ? audio-dft 89.459+-1.626 89.325+-0.683 audio-fft 33.649+-0.155 ? 33.750+-0.252 ? audio-oscillator 56.593+-0.723 ? 56.665+-0.477 ? imaging-darkroom 59.283+-0.884 58.876+-0.020 imaging-desaturate 47.141+-1.290 47.071+-0.707 imaging-gaussian-blur 80.007+-0.107 ? 80.399+-0.684 ? json-parse-financial 35.662+-0.471 35.545+-0.290 json-stringify-tinderbox 23.482+-0.208 23.451+-0.138 stanford-crypto-aes 38.539+-0.948 38.419+-0.563 stanford-crypto-ccm 33.157+-2.971 32.147+-2.066 might be 1.0314x faster stanford-crypto-pbkdf2 89.975+-1.398 89.934+-0.387 stanford-crypto-sha256-iterative 34.733+-0.370 34.494+-0.167 <arithmetic> 62.780+-0.349 62.598+-0.248 might be 1.0029x faster Conf#1 Conf#2 JSRegress: abc-forward-loop-equal 27.8579+-0.4108 ? 28.1482+-0.2607 ? might be 1.0104x slower abc-postfix-backward-loop 27.7670+-0.1016 ? 27.9999+-0.2686 ? abc-simple-backward-loop 27.5469+-0.2838 ? 27.5657+-0.7022 ? abc-simple-forward-loop 27.6017+-0.5219 27.5351+-0.4295 abc-skippy-loop 20.6262+-2.8202 19.7114+-0.3735 might be 1.0464x faster abs-boolean 2.2943+-0.1660 2.2520+-0.0818 might be 1.0188x faster adapt-to-double-divide 15.4792+-0.4080 15.3842+-0.4079 aliased-arguments-getbyval 1.0278+-0.0620 1.0030+-0.0408 might be 1.0247x faster allocate-big-object 2.5001+-0.2422 2.3749+-0.0933 might be 1.0527x faster arguments-named-and-reflective 10.5273+-0.8697 10.3767+-0.1502 might be 1.0145x faster arguments-out-of-bounds 8.6930+-0.4474 8.6498+-0.7496 arguments-strict-mode 9.4469+-0.5782 9.4251+-0.6584 arguments 8.1332+-0.2115 8.0029+-0.2748 might be 1.0163x faster arity-mismatch-inlining 0.7164+-0.0110 ? 0.7172+-0.0067 ? array-access-polymorphic-structure 5.4672+-0.1578 5.4164+-0.1104 array-nonarray-polymorhpic-access 22.9193+-0.2839 22.6255+-0.4580 might be 1.0130x faster array-prototype-every 70.9883+-0.4280 ? 71.1293+-1.2683 ? array-prototype-forEach 70.5693+-0.2785 70.5233+-1.5973 array-prototype-map 76.3383+-0.7360 ? 77.9821+-0.9531 ? might be 1.0215x slower array-prototype-reduce 67.9335+-1.1331 67.5758+-1.1672 array-prototype-reduceRight 67.4976+-1.5580 67.2153+-0.1340 array-prototype-some 70.5392+-0.3862 ? 71.1968+-0.9074 ? array-splice-contiguous 19.0486+-0.2809 ? 19.0796+-0.1838 ? array-with-double-add 3.2556+-0.1093 3.1727+-0.1577 might be 1.0261x faster array-with-double-increment 2.8126+-0.0821 ? 2.8217+-0.1445 ? array-with-double-mul-add 4.4344+-0.1884 ^ 3.8550+-0.1105 ^ definitely 1.1503x faster array-with-double-sum 2.8973+-0.0226 ? 2.9018+-0.0175 ? array-with-int32-add-sub 5.2452+-0.0509 5.1920+-0.0053 might be 1.0103x faster array-with-int32-or-double-sum 2.9748+-0.0952 2.9493+-0.0520 ArrayBuffer-DataView-alloc-large-long-lived 28.2079+-0.5575 ? 28.5042+-0.4662 ? might be 1.0105x slower ArrayBuffer-DataView-alloc-long-lived 11.2730+-0.3779 11.0870+-0.2849 might be 1.0168x faster ArrayBuffer-Int32Array-byteOffset 3.2957+-0.0110 ? 3.3381+-0.1191 ? might be 1.0129x slower ArrayBuffer-Int8Array-alloc-large-long-lived 29.0667+-0.9779 28.8323+-1.0210 ArrayBuffer-Int8Array-alloc-long-lived-buffer 18.9045+-1.1245 18.3793+-0.3015 might be 1.0286x faster ArrayBuffer-Int8Array-alloc-long-lived 10.6810+-0.1630 10.5688+-0.1580 might be 1.0106x faster ArrayBuffer-Int8Array-alloc 8.9114+-0.0901 ? 8.9363+-0.1425 ? arrowfunction-call 9.3242+-0.1408 9.1864+-0.1078 might be 1.0150x faster asmjs_bool_bug 6.4720+-0.1147 ? 7.3005+-2.7777 ? might be 1.1280x slower assign-custom-setter-polymorphic 2.2375+-0.1402 2.1865+-0.1796 might be 1.0233x faster assign-custom-setter 2.7999+-0.0035 ? 2.8666+-0.1300 ? might be 1.0238x slower basic-set 6.5721+-0.0537 ? 6.7352+-0.3229 ? might be 1.0248x slower big-int-mul 3.1935+-0.0699 ? 3.2079+-0.0888 ? boolean-test 2.7334+-0.1367 2.6991+-0.0557 might be 1.0127x faster branch-fold 3.3843+-0.1641 3.3170+-0.0119 might be 1.0203x faster branch-on-string-as-boolean 15.2968+-0.3426 ? 15.5778+-0.3354 ? might be 1.0184x slower by-val-generic 2.3082+-0.2148 2.2138+-0.0576 might be 1.0426x faster call-spread-apply 24.5915+-0.8748 ? 25.2537+-2.0282 ? might be 1.0269x slower call-spread-call 19.8568+-1.2224 19.5752+-0.2891 might be 1.0144x faster captured-assignments 0.3773+-0.0072 ? 0.3903+-0.0168 ? might be 1.0346x slower cast-int-to-double 4.8278+-0.2007 4.6847+-0.1283 might be 1.0305x faster cell-argument 5.8017+-0.2807 ? 5.9781+-0.4556 ? might be 1.0304x slower cfg-simplify 2.4885+-0.1375 ? 2.5730+-0.1494 ? might be 1.0339x slower chain-getter-access 7.6687+-0.1161 ? 8.0441+-0.7695 ? might be 1.0489x slower cmpeq-obj-to-obj-other 11.9935+-1.0143 ? 13.0316+-2.3901 ? might be 1.0866x slower constant-test 4.5112+-0.1253 ? 4.5237+-0.1470 ? create-lots-of-functions 10.3481+-0.1000 ? 10.4772+-0.3987 ? might be 1.0125x slower cse-new-array-buffer 2.0500+-0.0485 2.0217+-0.0252 might be 1.0140x faster cse-new-array 2.1010+-0.0428 ? 2.2158+-0.1322 ? might be 1.0546x slower DataView-custom-properties 33.2702+-0.4880 32.5659+-0.2811 might be 1.0216x faster delay-tear-off-arguments-strictmode 11.4671+-0.4180 ? 11.8644+-0.5952 ? might be 1.0347x slower deltablue-varargs 156.5034+-3.4104 153.9404+-3.2446 might be 1.0166x faster destructuring-arguments 154.5717+-1.4039 ! 157.6505+-1.6080 ! definitely 1.0199x slower destructuring-parameters-overridden-by-function 0.3927+-0.0256 ? 0.3982+-0.0479 ? might be 1.0140x slower destructuring-swap 4.3456+-0.0132 ? 4.4643+-0.1332 ? might be 1.0273x slower direct-arguments-getbyval 1.1030+-0.1127 1.0015+-0.0582 might be 1.1014x faster div-boolean-double 5.0415+-0.1734 4.9661+-0.0382 might be 1.0152x faster div-boolean 7.7180+-0.3067 7.7067+-0.1792 double-get-by-val-out-of-bounds 3.9000+-0.0893 ? 3.9196+-0.1215 ? double-pollution-getbyval 8.1384+-0.1338 ? 8.2151+-0.2448 ? double-pollution-putbyoffset 3.4629+-0.1980 3.4444+-0.2397 double-real-use 22.7330+-0.1815 ? 23.6956+-3.1431 ? might be 1.0423x slower double-to-int32-typed-array-no-inline 1.8427+-0.0766 ? 1.8543+-0.0794 ? double-to-int32-typed-array 1.6035+-0.0945 1.5761+-0.0241 might be 1.0173x faster double-to-uint32-typed-array-no-inline 1.8282+-0.0300 ? 1.8427+-0.0264 ? double-to-uint32-typed-array 1.7010+-0.0716 ? 1.7657+-0.1398 ? might be 1.0380x slower elidable-new-object-dag 38.5065+-0.5229 37.5328+-0.6141 might be 1.0259x faster elidable-new-object-roflcopter 36.6922+-0.8485 ? 36.9775+-1.1827 ? elidable-new-object-then-call 33.5645+-0.5856 ? 33.8604+-0.9270 ? elidable-new-object-tree 41.0575+-1.1555 ? 41.3312+-0.4477 ? empty-string-plus-int 4.6936+-0.2376 4.6145+-0.0654 might be 1.0171x faster emscripten-cube2hash 24.6097+-1.8574 ? 25.2512+-0.6303 ? might be 1.0261x slower exit-length-on-plain-object 11.1675+-0.2479 ? 11.2776+-0.4445 ? external-arguments-getbyval 0.9926+-0.0326 ? 1.0117+-0.1032 ? might be 1.0192x slower external-arguments-putbyval 1.8503+-0.0295 ? 2.0695+-0.3389 ? might be 1.1184x slower fixed-typed-array-storage-var-index 1.0804+-0.0816 1.0421+-0.0107 might be 1.0368x faster fixed-typed-array-storage 0.7982+-0.0900 0.7625+-0.0284 might be 1.0467x faster Float32Array-matrix-mult 3.5256+-0.1467 3.4550+-0.0396 might be 1.0204x faster Float32Array-to-Float64Array-set 45.5936+-0.3888 45.1052+-0.5203 might be 1.0108x faster Float64Array-alloc-long-lived 63.0988+-1.3264 63.0970+-1.6657 Float64Array-to-Int16Array-set 52.9104+-0.3824 ? 53.4017+-0.3108 ? fold-double-to-int 11.1589+-0.5562 ? 11.1688+-0.3403 ? fold-get-by-id-to-multi-get-by-offset-rare-int 11.0399+-1.4871 10.5298+-1.7268 might be 1.0484x faster fold-get-by-id-to-multi-get-by-offset 10.0757+-1.8978 ? 12.5450+-4.2951 ? might be 1.2451x slower fold-multi-get-by-offset-to-get-by-offset 8.9515+-0.9088 8.6055+-0.4253 might be 1.0402x faster fold-multi-get-by-offset-to-poly-get-by-offset 7.6062+-2.8391 7.4669+-1.9314 might be 1.0187x faster fold-multi-put-by-offset-to-poly-put-by-offset 8.3535+-1.3351 7.9199+-1.1190 might be 1.0547x faster fold-multi-put-by-offset-to-put-by-offset 3.9156+-0.8668 ? 4.4572+-0.7415 ? might be 1.1383x slower fold-multi-put-by-offset-to-replace-or-transition-put-by-offset 8.2035+-0.2552 8.0625+-0.0607 might be 1.0175x faster fold-put-by-id-to-multi-put-by-offset 8.8009+-0.4670 ? 10.2888+-4.1113 ? might be 1.1691x slower fold-put-by-val-with-string-to-multi-put-by-offset 9.4156+-0.9209 ? 10.5525+-4.0466 ? might be 1.1207x slower fold-put-by-val-with-symbol-to-multi-put-by-offset 11.3170+-3.8514 ? 12.5828+-3.6422 ? might be 1.1118x slower fold-put-structure 4.2817+-0.4434 ? 4.5891+-0.8355 ? might be 1.0718x slower for-of-iterate-array-entries 10.4866+-0.3313 10.4162+-0.3701 for-of-iterate-array-keys 3.0107+-0.1593 3.0069+-0.0508 for-of-iterate-array-values 3.1478+-0.1320 ? 3.2125+-0.0434 ? might be 1.0206x slower fround 16.2997+-0.4453 16.2335+-0.1348 ftl-library-inlining-dataview 52.5173+-0.4933 52.4336+-0.4410 ftl-library-inlining 106.0503+-0.2663 105.9667+-0.4210 function-call 9.4910+-0.3143 9.2318+-0.1426 might be 1.0281x faster function-dot-apply 1.7688+-0.0392 1.6633+-0.1490 might be 1.0634x faster function-test 2.5552+-0.1132 2.5438+-0.1783 function-with-eval 105.2397+-18.5281 98.7741+-1.0891 might be 1.0655x faster gcse-poly-get-less-obvious 13.2946+-0.1252 ? 13.4328+-0.1628 ? might be 1.0104x slower gcse-poly-get 15.0643+-0.0793 14.8812+-0.2878 might be 1.0123x faster gcse 3.5813+-0.1247 3.5499+-0.0662 get-by-id-bimorphic-check-structure-elimination-simple 2.4180+-0.1050 ? 2.4980+-0.1374 ? might be 1.0331x slower get-by-id-bimorphic-check-structure-elimination 5.3240+-0.0284 5.3000+-0.0807 get-by-id-chain-from-try-block 5.1047+-0.1643 ? 5.2192+-0.1940 ? might be 1.0224x slower get-by-id-check-structure-elimination 4.0768+-0.1258 4.0743+-0.1112 get-by-id-proto-or-self 13.8668+-0.5931 ? 13.9636+-0.9289 ? get-by-id-quadmorphic-check-structure-elimination-simple 2.6733+-0.1462 ? 2.7582+-0.1789 ? might be 1.0318x slower get-by-id-self-or-proto 14.1154+-1.6912 13.9621+-1.6830 might be 1.0110x faster get-by-val-out-of-bounds 3.6335+-0.1253 3.5841+-0.0741 might be 1.0138x faster get-by-val-with-string-bimorphic-check-structure-elimination-simple 2.5825+-0.0619 ? 2.5840+-0.0433 ? get-by-val-with-string-bimorphic-check-structure-elimination 5.5396+-0.0409 5.5045+-0.0272 get-by-val-with-string-chain-from-try-block 5.2307+-0.1205 5.0960+-0.0267 might be 1.0264x faster get-by-val-with-string-check-structure-elimination 4.8200+-0.1550 4.7893+-0.1798 get-by-val-with-string-proto-or-self 13.5915+-0.3300 ? 13.6962+-0.8311 ? get-by-val-with-string-quadmorphic-check-structure-elimination-simple 2.9551+-0.2201 2.8978+-0.0496 might be 1.0198x faster get-by-val-with-string-self-or-proto 14.5024+-1.9881 13.8704+-0.9425 might be 1.0456x faster get-by-val-with-symbol-bimorphic-check-structure-elimination-simple 2.7870+-0.0284 ? 2.9095+-0.1875 ? might be 1.0440x slower get-by-val-with-symbol-bimorphic-check-structure-elimination 11.5140+-0.2274 11.4642+-0.0372 get-by-val-with-symbol-chain-from-try-block 5.1824+-0.0777 ? 5.3014+-0.2571 ? might be 1.0230x slower get-by-val-with-symbol-check-structure-elimination 10.4321+-0.1889 10.3488+-0.0772 get-by-val-with-symbol-proto-or-self 13.8503+-1.3121 13.7745+-1.3559 get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple 3.6546+-0.1552 3.6542+-0.1299 get-by-val-with-symbol-self-or-proto 13.6302+-0.2219 ? 14.2280+-0.7189 ? might be 1.0439x slower get_callee_monomorphic 2.3099+-0.1193 ? 2.3380+-0.2184 ? might be 1.0122x slower get_callee_polymorphic 3.1363+-0.5351 2.9782+-0.0512 might be 1.0531x faster getter-no-activation 4.4750+-0.0198 ? 4.6111+-0.2213 ? might be 1.0304x slower getter-prototype 8.4955+-0.3578 8.2725+-0.2057 might be 1.0270x faster getter-richards 114.7879+-4.8258 ? 117.4500+-3.1789 ? might be 1.0232x slower getter 6.2271+-0.7404 5.3152+-1.1292 might be 1.1716x faster global-object-access-with-mutating-structure 5.4174+-0.3879 5.2888+-0.2920 might be 1.0243x faster global-var-const-infer-fire-from-opt 0.7242+-0.0822 ? 0.7659+-0.0841 ? might be 1.0576x slower global-var-const-infer 0.5440+-0.0547 0.5240+-0.0072 might be 1.0381x faster hard-overflow-check-equal 31.3734+-0.5120 31.2454+-0.3672 hard-overflow-check 30.9810+-0.2107 ? 31.1802+-0.9709 ? HashMap-put-get-iterate-keys 24.8210+-3.4999 ? 25.0607+-2.6566 ? HashMap-put-get-iterate 27.2309+-1.1300 ? 28.0471+-2.1802 ? might be 1.0300x slower HashMap-string-put-get-iterate 25.6000+-3.0047 24.3558+-2.1965 might be 1.0511x faster hoist-make-rope 9.4552+-0.4811 9.3881+-1.4409 hoist-poly-check-structure-effectful-loop 3.9324+-0.1366 3.7717+-0.1200 might be 1.0426x faster hoist-poly-check-structure 3.0303+-0.1136 3.0000+-0.0075 might be 1.0101x faster imul-double-only 7.2538+-0.1795 7.0469+-0.2191 might be 1.0294x faster imul-int-only 7.3526+-0.3983 ? 7.9780+-1.0348 ? might be 1.0851x slower imul-mixed 6.3770+-0.3982 6.3365+-0.6014 in-four-cases 15.9662+-0.1505 ^ 14.9737+-0.3280 ^ definitely 1.0663x faster in-one-case-false 9.5292+-0.8536 9.2237+-1.0210 might be 1.0331x faster in-one-case-true 8.9360+-0.2951 8.7916+-0.0615 might be 1.0164x faster in-two-cases 9.0830+-0.2170 ? 9.6348+-1.3102 ? might be 1.0607x slower indexed-properties-in-objects 2.5215+-0.0258 ? 2.5278+-0.0311 ? infer-closure-const-then-mov-no-inline 2.7787+-0.1497 2.7121+-0.0446 might be 1.0246x faster infer-closure-const-then-mov 16.6650+-0.3552 ? 17.2654+-1.2217 ? might be 1.0360x slower infer-closure-const-then-put-to-scope-no-inline 9.4173+-0.1603 ^ 8.9095+-0.0570 ^ definitely 1.0570x faster infer-closure-const-then-put-to-scope 20.1519+-0.7138 20.1196+-0.6757 infer-closure-const-then-reenter-no-inline 45.2499+-0.3893 ^ 42.5960+-0.2615 ^ definitely 1.0623x faster infer-closure-const-then-reenter 21.1060+-0.2168 20.9275+-0.1747 infer-constant-global-property 3.1843+-0.0858 3.1815+-0.1300 infer-constant-property 2.3658+-0.0144 ? 2.3841+-0.0375 ? infer-one-time-closure-ten-vars 7.0453+-0.3640 ? 7.2474+-0.3627 ? might be 1.0287x slower infer-one-time-closure-two-vars 6.7099+-0.4131 6.5801+-0.1357 might be 1.0197x faster infer-one-time-closure 6.7252+-0.2484 6.6270+-0.0743 might be 1.0148x faster infer-one-time-deep-closure 9.9355+-0.5960 9.8451+-0.2907 inline-arguments-access 3.6650+-0.1130 ? 3.9302+-0.3807 ? might be 1.0724x slower inline-arguments-aliased-access 3.6518+-0.0634 ? 3.8745+-0.4999 ? might be 1.0610x slower inline-arguments-local-escape 3.7220+-0.0492 3.6630+-0.0883 might be 1.0161x faster inline-get-scoped-var 4.4645+-0.3099 ? 4.5588+-0.2831 ? might be 1.0211x slower inlined-put-by-id-transition 10.6115+-0.3306 ? 10.6735+-0.3656 ? inlined-put-by-val-with-string-transition 66.9523+-1.9622 66.1875+-1.4887 might be 1.0116x faster inlined-put-by-val-with-symbol-transition 65.5618+-1.7554 65.0691+-2.0231 int-or-other-abs-then-get-by-val 4.4391+-0.1076 ? 4.4437+-0.0441 ? int-or-other-abs-zero-then-get-by-val 14.7135+-0.2342 ? 14.9240+-0.6048 ? might be 1.0143x slower int-or-other-add-then-get-by-val 3.7360+-0.3084 3.6646+-0.0499 might be 1.0195x faster int-or-other-add 4.5775+-0.1211 ? 4.6487+-0.2776 ? might be 1.0156x slower int-or-other-div-then-get-by-val 3.5956+-0.2004 3.5732+-0.1177 int-or-other-max-then-get-by-val 3.5610+-0.1609 3.5110+-0.0438 might be 1.0142x faster int-or-other-min-then-get-by-val 3.5837+-0.0164 ? 3.6573+-0.1364 ? might be 1.0205x slower int-or-other-mod-then-get-by-val 3.2960+-0.1145 3.1617+-0.0267 might be 1.0425x faster int-or-other-mul-then-get-by-val 3.3215+-0.1117 3.2784+-0.0077 might be 1.0131x faster int-or-other-neg-then-get-by-val 4.1442+-0.0229 ? 4.1730+-0.0967 ? int-or-other-neg-zero-then-get-by-val 14.8222+-0.2146 14.7346+-0.1169 int-or-other-sub-then-get-by-val 3.7168+-0.1152 ? 3.7966+-0.0794 ? might be 1.0215x slower int-or-other-sub 3.0925+-0.0124 ? 3.1547+-0.1722 ? might be 1.0201x slower int-overflow-local 3.8792+-0.1130 3.7708+-0.0890 might be 1.0287x faster Int16Array-alloc-long-lived 44.7894+-0.4404 44.5903+-1.0033 Int16Array-bubble-sort-with-byteLength 16.4383+-0.1866 ? 16.5715+-0.3569 ? Int16Array-bubble-sort 16.3190+-0.1412 16.2695+-0.2648 Int16Array-load-int-mul 1.2722+-0.0053 ? 1.2900+-0.0339 ? might be 1.0140x slower Int16Array-to-Int32Array-set 47.9236+-8.0663 45.1293+-2.7315 might be 1.0619x faster Int32Array-alloc-large 11.0779+-0.5286 ? 11.2367+-0.4408 ? might be 1.0143x slower Int32Array-alloc-long-lived 50.4641+-1.2532 ? 50.6745+-1.2230 ? Int32Array-alloc 3.1020+-0.4979 2.8304+-0.1947 might be 1.0960x faster Int32Array-Int8Array-view-alloc 5.5855+-0.2629 5.5753+-0.0846 int52-spill 4.1050+-0.0302 4.0855+-0.0887 Int8Array-alloc-long-lived 39.0753+-0.9372 ? 39.8910+-1.0437 ? might be 1.0209x slower Int8Array-load-with-byteLength 3.0912+-0.0231 3.0864+-0.0171 Int8Array-load 3.1771+-0.2487 3.1558+-0.1271 integer-divide 9.4878+-0.1539 ? 9.6245+-0.2350 ? might be 1.0144x slower integer-modulo 1.4108+-0.0079 ? 1.4323+-0.1444 ? might be 1.0152x slower is-boolean-fold-tricky 3.4900+-0.0801 ? 3.6317+-0.2392 ? might be 1.0406x slower is-boolean-fold 2.4845+-0.1399 2.4230+-0.1201 might be 1.0254x faster is-function-fold-tricky-internal-function 9.0883+-0.2057 8.9604+-0.2999 might be 1.0143x faster is-function-fold-tricky 3.7545+-0.0237 ? 3.7840+-0.0476 ? is-function-fold 2.4172+-0.0072 ? 2.4641+-0.1406 ? might be 1.0194x slower is-number-fold-tricky 3.7587+-0.1534 ? 3.7620+-0.1711 ? is-number-fold 2.4379+-0.0953 2.3820+-0.0108 might be 1.0235x faster is-object-or-null-fold-functions 2.4640+-0.1263 2.4307+-0.0431 might be 1.0137x faster is-object-or-null-fold-less-tricky 3.8443+-0.1634 3.7623+-0.0247 might be 1.0218x faster is-object-or-null-fold-tricky 4.7975+-0.1207 ? 4.9109+-0.3276 ? might be 1.0237x slower is-object-or-null-fold 2.4324+-0.0326 ? 2.4880+-0.1346 ? might be 1.0229x slower is-object-or-null-trickier-function 3.8464+-0.1133 ? 3.8615+-0.1751 ? is-object-or-null-trickier-internal-function 9.6127+-0.0583 ! 9.8956+-0.1451 ! definitely 1.0294x slower is-object-or-null-tricky-function 3.8818+-0.1838 3.7758+-0.0271 might be 1.0281x faster is-object-or-null-tricky-internal-function 7.2137+-0.2726 7.1735+-0.0933 is-string-fold-tricky 3.8078+-0.1273 ? 3.8212+-0.1025 ? is-string-fold 2.4525+-0.1490 2.4150+-0.0824 might be 1.0155x faster is-undefined-fold-tricky 3.0472+-0.0404 ? 3.0814+-0.1123 ? might be 1.0112x slower is-undefined-fold 2.4205+-0.0583 2.3890+-0.0040 might be 1.0132x faster JSONP-negative-0 0.2545+-0.0497 0.2390+-0.0292 might be 1.0651x faster large-int-captured 3.8992+-0.0806 3.7963+-0.0980 might be 1.0271x faster large-int-neg 12.7927+-0.2842 ? 12.8813+-0.3012 ? large-int 11.7637+-0.1554 ? 11.7794+-0.4059 ? load-varargs-elimination 19.4355+-0.7247 ? 20.1893+-0.3693 ? might be 1.0388x slower logical-not-weird-types 2.5307+-0.0801 ? 2.5914+-0.0838 ? might be 1.0240x slower logical-not 3.7766+-0.1807 3.7525+-0.0885 lots-of-fields 9.1650+-0.1533 8.9341+-0.2504 might be 1.0258x faster make-indexed-storage 2.4340+-0.3366 ? 2.5192+-0.0599 ? might be 1.0350x slower make-rope-cse 4.1281+-0.2114 4.0496+-0.0087 might be 1.0194x faster marsaglia-larger-ints 29.7148+-0.7009 ? 29.7277+-0.4007 ? marsaglia-osr-entry 19.8562+-0.2352 19.7070+-0.3417 math-with-out-of-bounds-array-values 19.8117+-0.1719 ? 19.9186+-0.3433 ? max-boolean 2.4145+-0.0627 ? 2.5288+-0.1320 ? might be 1.0473x slower method-on-number 17.3552+-1.2293 ^ 15.6536+-0.3685 ^ definitely 1.1087x faster min-boolean 2.4276+-0.1783 2.4188+-0.0848 minus-boolean-double 2.8478+-0.0512 2.8203+-0.0181 minus-boolean 2.1442+-0.0733 2.1422+-0.0730 misc-strict-eq 26.5516+-1.3313 ? 27.5837+-2.3575 ? might be 1.0389x slower mod-boolean-double 10.3485+-0.0540 ? 10.3712+-0.2237 ? mod-boolean 7.8073+-0.1576 7.7366+-0.0142 mul-boolean-double 3.3691+-0.1288 ? 3.3824+-0.1634 ? mul-boolean 2.5723+-0.0092 ? 2.6332+-0.2249 ? might be 1.0237x slower neg-boolean 2.9027+-0.1981 ? 2.9208+-0.1342 ? negative-zero-divide 0.3017+-0.0062 0.2963+-0.0060 might be 1.0181x faster negative-zero-modulo 0.3068+-0.0355 0.2994+-0.0045 might be 1.0245x faster negative-zero-negate 0.2974+-0.0580 ? 0.3029+-0.0394 ? might be 1.0183x slower nested-function-parsing 43.1973+-0.3760 ? 43.6952+-1.0773 ? might be 1.0115x slower new-array-buffer-dead 98.7883+-1.9803 98.6498+-0.2119 new-array-buffer-push 6.0308+-0.0991 ? 6.0820+-0.0822 ? new-array-dead 15.1055+-0.1572 14.9655+-0.5549 new-array-push 3.3909+-0.0460 ? 3.4795+-0.2692 ? might be 1.0261x slower no-inline-constructor 33.4642+-0.3778 33.3082+-0.3789 number-test 2.7139+-0.0453 ? 2.7338+-0.0822 ? object-closure-call 4.3809+-0.0128 ? 4.4210+-0.1203 ? object-get-own-property-symbols-on-large-array 3.6203+-0.1511 ? 3.6237+-0.2570 ? object-test 2.4774+-0.0535 ? 2.4897+-0.0894 ? obvious-sink-pathology-taken 116.1895+-1.5306 ? 117.8603+-1.2046 ? might be 1.0144x slower obvious-sink-pathology 111.3760+-2.0056 ? 112.6646+-2.1864 ? might be 1.0116x slower obviously-elidable-new-object 31.0970+-0.6233 ? 31.3022+-0.8362 ? plus-boolean-arith 2.2345+-0.0889 2.1859+-0.0531 might be 1.0223x faster plus-boolean-double 2.8967+-0.2154 2.8425+-0.0227 might be 1.0191x faster plus-boolean 2.3530+-0.1366 2.2893+-0.1059 might be 1.0278x faster poly-chain-access-different-prototypes-simple 3.0074+-0.1535 3.0005+-0.0684 poly-chain-access-different-prototypes 2.6461+-0.1136 2.6313+-0.0804 poly-chain-access-simpler 3.0412+-0.0829 ? 3.0516+-0.1887 ? poly-chain-access 3.2048+-0.2678 3.0388+-0.2156 might be 1.0546x faster poly-stricteq 46.1563+-0.1027 ! 48.2513+-0.5560 ! definitely 1.0454x slower polymorphic-array-call 1.0402+-0.0546 ? 1.1055+-0.0679 ? might be 1.0628x slower polymorphic-get-by-id 2.6277+-0.1029 ? 2.7131+-0.2779 ? might be 1.0325x slower polymorphic-put-by-id 23.1467+-0.5442 22.8932+-0.6246 might be 1.0111x faster polymorphic-put-by-val-with-string 23.9709+-0.3718 23.5396+-0.4415 might be 1.0183x faster polymorphic-put-by-val-with-symbol 23.6823+-0.3037 ? 23.7105+-0.4057 ? polymorphic-structure 12.4570+-0.1787 ? 12.4691+-0.1722 ? polyvariant-monomorphic-get-by-id 6.0880+-1.3228 ? 6.5959+-1.6128 ? might be 1.0834x slower proto-getter-access 7.7934+-0.2683 7.6528+-0.1602 might be 1.0184x faster prototype-access-with-mutating-prototype 5.0481+-0.1405 4.9651+-0.0513 might be 1.0167x faster put-by-id-replace-and-transition 7.7993+-0.3954 7.5987+-0.2418 might be 1.0264x faster put-by-id-slightly-polymorphic 2.4391+-0.1134 2.4045+-0.0752 might be 1.0144x faster put-by-id 11.5734+-0.0635 11.5474+-0.1445 put-by-val-direct 0.3203+-0.0761 0.3025+-0.0126 might be 1.0589x faster put-by-val-large-index-blank-indexing-type 4.9111+-0.1166 ? 4.9430+-0.2172 ? put-by-val-machine-int 2.2723+-0.1903 2.1871+-0.0971 might be 1.0390x faster put-by-val-with-string-replace-and-transition 11.9325+-0.3103 ? 11.9969+-0.3334 ? put-by-val-with-string-slightly-polymorphic 2.6923+-0.1336 2.6775+-0.1723 put-by-val-with-string 12.0525+-0.2619 11.8956+-0.2911 might be 1.0132x faster put-by-val-with-symbol-replace-and-transition 13.0018+-0.3071 ? 13.2103+-0.7792 ? might be 1.0160x slower put-by-val-with-symbol-slightly-polymorphic 2.9119+-0.0703 2.8868+-0.0404 put-by-val-with-symbol 11.8898+-0.2226 11.8829+-0.1343 rare-osr-exit-on-local 13.6837+-0.3098 13.6385+-0.2378 register-pressure-from-osr 15.6175+-0.1930 ? 15.6661+-0.5088 ? repeat-multi-get-by-offset 19.9644+-0.2713 19.8628+-0.1024 setter-prototype 7.2578+-0.2320 ? 7.2786+-0.2038 ? setter 5.5235+-1.0504 5.2489+-0.5473 might be 1.0523x faster simple-activation-demo 23.0216+-0.7782 22.6130+-0.1502 might be 1.0181x faster simple-getter-access 9.9147+-0.3843 9.7540+-0.2378 might be 1.0165x faster simple-poly-call-nested 7.9240+-1.5912 ? 8.5242+-2.1146 ? might be 1.0758x slower simple-poly-call 1.0443+-0.0276 1.0310+-0.0156 might be 1.0128x faster sin-boolean 17.1450+-0.7752 16.4548+-0.3213 might be 1.0419x faster singleton-scope 50.1572+-0.3507 ? 50.2131+-0.1706 ? sink-function 9.3192+-1.0842 ? 9.7800+-1.6396 ? might be 1.0494x slower sink-huge-activation 15.7979+-0.6043 15.7531+-0.4735 sinkable-new-object-dag 59.2578+-2.3882 58.4623+-2.1667 might be 1.0136x faster sinkable-new-object-taken 42.2830+-0.1911 ? 42.6152+-0.9100 ? sinkable-new-object 31.6581+-0.3400 ? 31.7962+-0.2074 ? slow-array-profile-convergence 2.1207+-0.1398 ? 2.1645+-0.0859 ? might be 1.0207x slower slow-convergence 2.0814+-0.0886 ? 2.2613+-0.3103 ? might be 1.0864x slower slow-ternaries 16.3325+-0.2652 ? 16.7043+-0.3845 ? might be 1.0228x slower sorting-benchmark 15.8619+-0.4713 15.5262+-0.5671 might be 1.0216x faster sparse-conditional 1.0085+-0.0138 1.0055+-0.0185 splice-to-remove 11.3573+-0.3023 ? 11.4407+-0.3265 ? string-char-code-at 13.1131+-0.1462 ! 15.6440+-0.2364 ! definitely 1.1930x slower string-concat-object 2.1835+-0.2313 ? 2.2972+-0.2882 ? might be 1.0521x slower string-concat-pair-object 2.0541+-0.0394 ? 2.1223+-0.1802 ? might be 1.0332x slower string-concat-pair-simple 10.6091+-0.2234 10.2634+-0.3230 might be 1.0337x faster string-concat-simple 10.6757+-0.5129 10.3314+-0.2130 might be 1.0333x faster string-cons-repeat 7.2210+-0.1414 ? 7.3149+-0.5708 ? might be 1.0130x slower string-cons-tower 7.4392+-0.0447 7.2830+-0.2142 might be 1.0214x faster string-equality 14.0908+-0.0046 ? 14.1295+-0.1220 ? string-get-by-val-big-char 6.1905+-0.0729 ? 6.5230+-0.8362 ? might be 1.0537x slower string-get-by-val-out-of-bounds-insane 2.8663+-0.0760 ? 2.9288+-0.1674 ? might be 1.0218x slower string-get-by-val-out-of-bounds 3.7903+-0.1759 3.7305+-0.3143 might be 1.0160x faster string-get-by-val 2.5820+-0.0176 ? 2.6285+-0.1432 ? might be 1.0180x slower string-hash 1.6987+-0.0327 ? 1.8117+-0.1102 ? might be 1.0665x slower string-long-ident-equality 11.6220+-0.0504 ? 11.7062+-0.1913 ? string-out-of-bounds 9.0784+-0.3417 ? 9.2754+-0.1924 ? might be 1.0217x slower string-repeat-arith 26.2760+-0.2576 ^ 25.5542+-0.4188 ^ definitely 1.0282x faster string-sub 50.1844+-1.4406 49.6492+-0.7831 might be 1.0108x faster string-test 2.5923+-0.0667 ? 2.6368+-0.1005 ? might be 1.0171x slower string-var-equality 23.5361+-0.0454 ! 24.3335+-0.6711 ! definitely 1.0339x slower structure-hoist-over-transitions 2.2792+-0.1683 2.2283+-0.0233 might be 1.0228x faster substring-concat-weird 36.3133+-1.2183 ? 36.4238+-0.4922 ? substring-concat 39.1008+-0.4493 ? 39.2661+-1.0932 ? substring 43.6465+-0.7766 43.5801+-0.4665 switch-char-constant 2.6074+-0.2052 ? 2.6183+-0.0759 ? switch-char 5.8842+-1.3596 5.4532+-0.7950 might be 1.0790x faster switch-constant 7.4662+-0.1438 ? 7.4844+-0.1530 ? switch-string-basic-big-var 12.9047+-0.2308 ? 13.1714+-0.8685 ? might be 1.0207x slower switch-string-basic-big 13.3313+-0.2937 13.2363+-0.1641 switch-string-basic-var 12.2184+-0.2899 12.1664+-0.3617 switch-string-basic 11.5300+-0.2478 11.4610+-0.1512 switch-string-big-length-tower-var 16.6990+-0.1916 ? 16.7549+-0.5002 ? switch-string-length-tower-var 12.1281+-0.2382 ? 12.1715+-0.1304 ? switch-string-length-tower 11.0504+-0.0655 10.9495+-0.2729 switch-string-short 11.0099+-0.2306 ? 11.0153+-0.2293 ? switch 10.8685+-0.0991 10.8641+-0.3415 tear-off-arguments-simple 2.8730+-0.1006 2.8622+-0.0777 tear-off-arguments 3.7927+-0.0408 ? 3.8118+-0.1014 ? temporal-structure 11.2547+-0.2680 11.1858+-0.1775 to-int32-boolean 11.7668+-0.0827 11.6744+-0.1761 try-catch-get-by-val-cloned-arguments 12.9692+-0.2230 ? 13.0060+-0.2156 ? try-catch-get-by-val-direct-arguments 5.8270+-0.0244 ? 5.9637+-0.2764 ? might be 1.0235x slower try-catch-get-by-val-scoped-arguments 6.8212+-0.2127 ? 6.8591+-0.0943 ? typed-array-get-set-by-val-profiling 25.8767+-0.4617 25.8103+-0.6424 undefined-property-access 213.8142+-0.3050 ? 214.1931+-0.9072 ? undefined-test 2.7692+-0.0918 2.7457+-0.0275 unprofiled-licm 12.8215+-0.3884 ? 12.8960+-0.2134 ? varargs-call 11.5720+-0.1454 11.5307+-0.2178 varargs-construct-inline 23.1807+-0.8731 ? 23.2332+-0.2067 ? varargs-construct 18.5884+-0.4787 18.4913+-0.2664 varargs-inline 7.6448+-0.2343 7.3889+-0.2359 might be 1.0346x faster varargs-strict-mode 8.2668+-0.2410 7.9913+-0.4639 might be 1.0345x faster varargs 8.1146+-0.1421 7.8668+-0.1332 might be 1.0315x faster weird-inlining-const-prop 1.9058+-0.1777 ? 1.9255+-0.1495 ? might be 1.0104x slower <geometric> 7.3674+-0.0143 ? 7.3740+-0.0398 ? might be 1.0009x slower Conf#1 Conf#2 AsmBench: bigfib.cpp 436.2346+-8.2575 430.8919+-9.8138 might be 1.0124x faster cray.c 376.6687+-5.5490 376.5784+-1.2184 dry.c 412.8593+-4.0551 407.4407+-14.0912 might be 1.0133x faster FloatMM.c 660.9310+-1.2332 ? 661.6540+-2.9164 ? gcc-loops.cpp 3314.7715+-26.3569 3310.2445+-21.2555 n-body.c 795.9218+-0.4697 ? 796.4238+-2.1641 ? Quicksort.c 392.1550+-6.4622 ? 393.5872+-0.7600 ? stepanov_container.cpp 3328.8685+-39.6232 3286.1583+-26.9616 might be 1.0130x faster Towers.c 223.6194+-0.3599 223.0676+-1.4712 <geometric> 687.9765+-3.0580 685.1333+-2.9213 might be 1.0041x faster Conf#1 Conf#2 CompressionBench: huffman 48.0612+-1.8503 ? 48.3552+-1.1081 ? arithmetic-simple 258.0961+-0.7928 ? 258.2814+-2.2294 ? arithmetic-precise 230.9376+-2.3474 ? 231.4913+-1.0854 ? arithmetic-complex-precise 233.4617+-1.3888 ? 237.3903+-5.2494 ? might be 1.0168x slower arithmetic-precise-order-0 269.8860+-2.8805 ? 273.2766+-5.5263 ? might be 1.0126x slower arithmetic-precise-order-1 292.0842+-3.4157 ? 293.3721+-3.3172 ? arithmetic-precise-order-2 335.7793+-2.0841 ? 336.3224+-2.2498 ? arithmetic-simple-order-1 310.2921+-1.9373 ! 315.0058+-0.7596 ! definitely 1.0152x slower arithmetic-simple-order-2 358.4599+-2.6944 ? 364.6550+-10.1871 ? might be 1.0173x slower lz-string 281.6200+-2.3007 ? 288.6012+-8.0192 ? might be 1.0248x slower <geometric> 236.7980+-0.9314 ! 239.1996+-0.6100 ! definitely 1.0101x slower Conf#1 Conf#2 Geomean of preferred means: <scaled-result> 48.7610+-0.1428 48.7410+-0.1247 might be 1.0004x faster

Geoffrey Garen

Comment 3 2015-08-27 14:40:49 PDT

Comment on attachment 260084 [details] Patch r=me

Benjamin Poulain

Comment 4 2015-08-27 20:35:16 PDT

Created attachment 260112 [details] Patch

Benjamin Poulain

Comment 5 2015-08-28 18:57:20 PDT

Comment on attachment 260112 [details] Patch Clearing flags on attachment: 260112 Committed r189136: <http://trac.webkit.org/changeset/189136>

Benjamin Poulain

Comment 6 2015-08-28 18:57:24 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 7 2015-08-28 23:17:48 PDT

This looks like it made JSC tests flaky: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20JSC%20(Tests)?numbuilds=50 Please yell ASAP if this shouldn't be rolled out.

WebKit Commit Bot

Comment 8 2015-08-28 23:48:53 PDT

Re-opened since this is blocked by bug 148608

Alexey Proskuryakov

Comment 9 2015-08-28 23:53:05 PDT

Rolled out in https://trac.webkit.org/r189148

Benjamin Poulain

Comment 10 2015-08-29 23:56:25 PDT

(In reply to comment #9) > Rolled out in https://trac.webkit.org/r189148 Thanks for rolling out Alexey. I don't know why the test were flaky, they worked locally in debug.

Alexey Proskuryakov

Comment 11 2015-08-30 10:15:34 PDT

On the bots, this was more frequently happening on release ones.

Benjamin Poulain

Comment 12 2016-03-05 01:11:07 PST

*** This bug has been marked as a duplicate of bug 155055 ***

Attachments
Patch (10.23 KB, patch) 2015-08-27 14:00 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (11.73 KB, patch) 2015-08-27 20:35 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.