RESOLVED FIXED 148535
The status message for combined builder queues should say "all builds passed" if everything built correctly. 
https://bugs.webkit.org/show_bug.cgi?id=148535
Summary The status message for combined builder queues should say "all builds passed"...
Jason Marcell
Reported 2015-08-27 11:40:51 PDT
The status message for combined builder queues should say "all builds passed" if everything built correctly.
Attachments
Patch (2.08 KB, patch)
2015-08-27 11:43 PDT, Jason Marcell 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2015-08-27 17:22 PDT, Jason Marcell 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2015-08-28 10:47 PDT, Jason Marcell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jason Marcell
Comment 1 2015-08-27 11:43:41 PDT
Created attachment 260073 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2015-08-27 16:57:34 PDT
Comment on attachment 260073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260073&action=review r=me if you fix the nit. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:90 > + var statusMessagePassed = "all " + (queue.builder ? "builds" : "tests") + " passed" Nit: This should have a semi-colon at the end of the line.
Jason Marcell
Comment 3 2015-08-27 17:22:32 PDT
Created attachment 260099 [details] Patch
David Kilzer (:ddkilzer)
Comment 4 2015-08-27 17:33:02 PDT
Comment on attachment 260099 [details] Patch r=me
Alexey Proskuryakov
Comment 5 2015-08-28 08:58:22 PDT
This should probably be "all builds succeeded", not "all builds passed".
Jason Marcell
Comment 6 2015-08-28 10:47:17 PDT
Created attachment 260163 [details] Patch
WebKit Commit Bot
Comment 7 2015-08-28 11:13:55 PDT
Comment on attachment 260163 [details] Patch Clearing flags on attachment: 260163 Committed r189106: <http://trac.webkit.org/changeset/189106>
WebKit Commit Bot
Comment 8 2015-08-28 11:13:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.