Bug 148522 - [GStreamer] Cleanup the iradio properties
Summary: [GStreamer] Cleanup the iradio properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-08-27 03:45 PDT by Carlos Garcia Campos
Modified: 2015-11-03 02:41 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.27 KB, patch)
2015-08-27 03:47 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (8.02 KB, patch)
2015-11-02 08:52 PST, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-08-27 03:45:38 PDT 
We could use CString instead of char* to avoid all the g_strdup()/g_free().
Comment 1 Carlos Garcia Campos 2015-08-27 03:47:29 PDT 
Created attachment 260050 [details]
Patch
Comment 2 Philippe Normand 2015-08-27 03:52:06 PDT 
Sebastian, why are these iradio properties needed? I always wondered about this :)
Comment 3 Sebastian Dröge (slomo) 2015-08-27 04:09:45 PDT 
0.10 crap :) The properties except for iradio-mode can definitely go away as long as the things are also posted as tags on the bus. iradio-mode might be useful if you want to disable sending that special HTTP header to servers. There might be some confused by it, who knows.
Comment 4 Carlos Garcia Campos 2015-11-02 08:52:10 PST 
Created attachment 264592 [details]
Patch

Is this better then?
Comment 5 Philippe Normand 2015-11-03 01:49:17 PST 
Comment on attachment 264592 [details]
Patch

Nice :)
Comment 6 Carlos Garcia Campos 2015-11-03 02:41:05 PST 
Committed r191947: <http://trac.webkit.org/changeset/191947>