Bug 148516 – AX: Fix accessibility/select-element-at-index.html test

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

Test is marked skip in TestExpectation file.

[Nan Wang]

Created attachment 260042 [details]
patch

[Nan Wang]

Created attachment 260043 [details]
patch

[Nan Wang]

Created attachment 260045 [details]
patch

[chris fleizach]

Comment on attachment 260045 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260045&action=review

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:487
> +    int indexNumber = -1;

can we make this unsigned then we don't have to worry about >= 0

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:498
> +    int indexNumber = -1;

ditto

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1408
> +    NSArray* selected = [m_element accessibilityAttributeValue:NSAccessibilitySelectedChildrenAttribute];

* is on wrong side because this is ObjC code. 
selected -> selectedChildren

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1409
> +    NSArray* array = [NSArray arrayWithObject:element.platformUIElement()];

ditto about *

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1420
> +    NSArray* selected = [m_element accessibilityAttributeValue:NSAccessibilitySelectedChildrenAttribute];

ditto

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1423
> +    NSMutableArray* array = [NSMutableArray arrayWithArray:selected];

ditto

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1448
> +    NSArray* array = [NSArray arrayWithObject:element->platformUIElement()];

ditto

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1459
> +    NSArray* selected = [m_element accessibilityAttributeValue:NSAccessibilitySelectedChildrenAttribute];

ditto

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1464
> +    [m_element accessibilitySetValue:array forAttribute:NSAccessibilitySelectedChildrenAttribute];

i see that when we use this it performs it async which makes testing hard. there is a method

- (void)_accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName

that is not async

[Nan Wang]

Created attachment 260070 [details]
patch

[chris fleizach]

Comment on attachment 260070 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260070&action=review

> LayoutTests/accessibility/select-element-at-index.html:48
> +        if (accessibilityController.platformName == "mac") 

can you add a comment why this is necessary

[Nan Wang]

Created attachment 260072 [details]
patch

[Nan Wang]

Created attachment 260075 [details]
patch

Fix iOS build failure

[WebKit Commit Bot]

Comment on attachment 260075 [details]
patch

Clearing flags on attachment: 260075

Committed r189044: <http://trac.webkit.org/changeset/189044>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.