Bug 148515 - Web Inspector: Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager
Summary: Web Inspector: Standardize on CSSStyleSheet.Type enum and move more protocol ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-08-26 23:20 PDT by Joseph Pecoraro
Modified: 2015-08-27 10:37 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (22.58 KB, patch)
2015-08-26 23:23 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-08-26 23:20:27 PDT
* SUMMARY
Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager.

`CSS.CSSRule` protocol types send a `CSS.StyleSheetOrigin` enum to the frontend. So we should be using CSSStyleSheet.Type instead of CSSRule.Type.
Comment 1 Joseph Pecoraro 2015-08-26 23:23:00 PDT
Created attachment 260038 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2015-08-27 08:26:49 PDT
Comment on attachment 260038 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2015-08-27 10:37:40 PDT
Comment on attachment 260038 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260038

Committed r189032: <http://trac.webkit.org/changeset/189032>
Comment 4 WebKit Commit Bot 2015-08-27 10:37:44 PDT
All reviewed patches have been landed.  Closing bug.