Bug 148509 - Factor out Lookup invocation
Summary: Factor out Lookup invocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-26 19:54 PDT by Tim Horton
Modified: 2015-08-27 14:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (70.31 KB, patch)
2015-08-26 19:55 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (73.34 KB, patch)
2015-08-27 12:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (75.48 KB, patch)
2015-08-27 12:11 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (76.00 KB, patch)
2015-08-27 12:20 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-08-26 19:54:35 PDT 
Factor out Lookup invocation
Comment 1 Tim Horton 2015-08-26 19:55:17 PDT 
Created attachment 260022 [details]
Patch
Comment 2 Tim Horton 2015-08-27 12:09:21 PDT 
Created attachment 260076 [details]
Patch
Comment 3 Tim Horton 2015-08-27 12:11:57 PDT 
Created attachment 260077 [details]
Patch
Comment 4 Tim Horton 2015-08-27 12:20:08 PDT 
Created attachment 260079 [details]
Patch
Comment 5 Anders Carlsson 2015-08-27 14:16:30 PDT 
Comment on attachment 260079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260079&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470
> +    return (id<NSImmediateActionAnimationController>)DictionaryLookup::animationControllerForPopup(dictionaryPopupInfo, _wkView, [self](TextIndicator& textIndicator) {

Why do you need the cast here?
Comment 6 Tim Horton 2015-08-27 14:19:00 PDT 
(In reply to comment #5)
> Comment on attachment 260079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260079&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470
> > +    return (id<NSImmediateActionAnimationController>)DictionaryLookup::animationControllerForPopup(dictionaryPopupInfo, _wkView, [self](TextIndicator& textIndicator) {
> 
> Why do you need the cast here?

I don't, anymore! (In a previous version of the patch, it always returned void*)
Comment 7 Tim Horton 2015-08-27 14:25:09 PDT 
http://trac.webkit.org/changeset/189052