Bug 148505 - Update Grid Layout to use fewer magic -1s
Summary: Update Grid Layout to use fewer magic -1s
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-26 17:48 PDT by Myles C. Maxfield
Modified: 2015-08-27 11:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.90 KB, patch)
2015-08-26 17:50 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2015-08-26 23:00 PDT, Myles C. Maxfield 		jfernandez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-26 17:48:26 PDT 
Update Grid Layout to use fewer magic -1s
Comment 1 Myles C. Maxfield 2015-08-26 17:50:10 PDT 
Created attachment 260010 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-26 23:00:52 PDT 
Created attachment 260035 [details]
Patch
Comment 3 Javier Fernandez 2015-08-27 01:10:44 PDT 
Comment on attachment 260010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260010&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1301
> +    ASSERT(child.overrideContainingBlockContentLogicalWidth());

Shouldn't we assert child.overrideContainingBlockContentLogicalHeight() as well ?
Comment 4 Myles C. Maxfield 2015-08-27 11:04:01 PDT 
Committed r189037: <http://trac.webkit.org/changeset/189037>