Bug 148486 - Media Session: make MediaSessionMetadata a class
Summary: Media Session: make MediaSessionMetadata a class
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2015-08-26 11:30 PDT by Eric Carlson
Modified: 2015-09-04 03:57 PDT (History)
3 users (show)

See Also:

Proposed patch (3.06 KB, patch)
2015-08-26 11:39 PDT, Eric Carlson
jer.noble: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing. (3.02 KB, patch)
2015-08-26 12:35 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-08-26 11:30:43 PDT
MediaSessionMetadata is defined as a struct, but it is forward declared in several places as a class. Make it a class and rectify the errant forward declarations.
Comment 1 Eric Carlson 2015-08-26 11:39:42 PDT
Created attachment 259966 [details]
Proposed patch
Comment 2 Radar WebKit Bug Importer 2015-08-26 12:09:54 PDT
Comment 3 WebKit Commit Bot 2015-08-26 12:19:13 PDT
Comment on attachment 259966 [details]
Proposed patch

Rejecting attachment 259966 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 259966, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej
patching file Source/WebCore/Modules/mediasession/MediaSessionMetadata.h
patching file Source/WebCore/page/ChromeClient.h
patching file Source/WebKit2/ChangeLog
patching file Source/WebKit2/Shared/WebCoreArgumentCoders.h
patching file Source/WebKit2/UIProcess/WebPageProxy.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/109924
Comment 4 Eric Carlson 2015-08-26 12:35:51 PDT
Created attachment 259969 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2015-08-26 13:29:22 PDT
Comment on attachment 259969 [details]
Patch for landing.

Clearing flags on attachment: 259969

Committed r188983: <http://trac.webkit.org/changeset/188983>
Comment 6 Csaba Osztrogonác 2015-09-04 03:57:55 PDT
Already landed, let's close it.