Bug 148478 - [JSC] StructureTransitionTable should eagerly deallocate single-transition WeakImpls.
Summary: [JSC] StructureTransitionTable should eagerly deallocate single-transition We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2015-08-26 08:28 PDT by Andreas Kling
Modified: 2015-08-26 12:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2015-08-26 08:42 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-08-26 08:28:52 PDT 
When using the single-transition optimization, StructureTransitionTable sometimes holds on to a WeakImpl after its pointee has been collected.
This causes us to unnecessarily extend the lifetime of WeakBlocks.
Comment 1 Andreas Kling 2015-08-26 08:42:53 PDT 
Created attachment 259953 [details]
Patch
Comment 2 Geoffrey Garen 2015-08-26 11:01:55 PDT 
Comment on attachment 259953 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-08-26 12:21:35 PDT 
Comment on attachment 259953 [details]
Patch

Clearing flags on attachment: 259953

Committed r188978: <http://trac.webkit.org/changeset/188978>
Comment 4 WebKit Commit Bot 2015-08-26 12:21:38 PDT 
All reviewed patches have been landed.  Closing bug.