Bug 148464 - [Cocoa] PerformanceTest Layout/RegionsShapes.html is failing
Summary: [Cocoa] PerformanceTest Layout/RegionsShapes.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-25 22:05 PDT by Myles C. Maxfield
Modified: 2015-08-26 17:20 PDT (History)
0 users

See Also:

Attachments
Patch (3.23 KB, patch)
2015-08-25 22:08 PDT, Myles C. Maxfield 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-25 22:05:35 PDT 
[Cocoa] PerformanceTest Layout/RegionsShapes.html is failing
Comment 1 Myles C. Maxfield 2015-08-25 22:08:38 PDT 
Created attachment 259924 [details]
Patch
Comment 2 Andy Estes 2015-08-25 22:42:23 PDT 
Comment on attachment 259924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259924&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:472
> +    RetainPtr<CFDictionaryRef> attributes = adoptCF(CFDictionaryCreate(kCFAllocatorDefault, keys, values, WTF_ARRAY_LENGTH(keys), &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +    RetainPtr<CTFontDescriptorRef> descriptor = adoptCF(CTFontDescriptorCreateWithAttributes(attributes.get()));

I like to use auto in these cases.
Comment 3 Myles C. Maxfield 2015-08-26 17:20:33 PDT 
Committed r189005: <http://trac.webkit.org/changeset/189005>