Bug 148449 – A WebIDL callback interface is allowed to have constants

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

A WebIDL callback interface is allowed to have constants. Currently, our bindings generator does not support that.

Spec for constants:
https://heycam.github.io/webidl/#dfn-constant

Part about constants and callback interfaces:
https://heycam.github.io/webidl/#es-user-objects
"The [NoInterfaceObject] extended attribute must not be specified on a callback interface unless it has a constant declared on it. This is because callback interfaces without constants never have interface objects."

The callback interface should also have a corresponding property on the global object if they are constants:
https://heycam.github.io/webidl/#es-interfaces

[Chris Dumez]

Created attachment 260085 [details]
Patch

[WebKit Commit Bot]

Attachment 260085 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/ObjC/DOMTestCallback.h:37:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/scripts/test/ObjC/DOMTestCallback.h:38:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 260085 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 260085 [details]
Patch

Clearing flags on attachment: 260085

Committed r189063: <http://trac.webkit.org/changeset/189063>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.