Bug 148436 – Web Inspector: Styles sidebar says Media: all when it should say Media: screen

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Created attachment 259860 [details]
Screenshot

On daring fireball.net, the stylesheets are media="screen", however the sidebar says Media: all.

The Copy Rule context menu does include the media as screen, so the data is there we are just showing the wrong thing.

[Radar WebKit Bug Importer]

<rdar://problem/22421857>

[Devin Rousso]

Created attachment 260943 [details]
Patch

[Blaze Burg]

Comment on attachment 260943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260943&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:193
> +            var currentMediaList = style.ownerRule && style.ownerRule.mediaList;

This change removes the fallback to [] if both are null. Maybe you should add || [] ?

[Devin Rousso]

(In reply to comment #3)
> This change removes the fallback to [] if both are null. Maybe you should
> add || [] ?

It shouldn't be an issue when both are null, but I can see an issue when only one is null and the other isn't.  I'll add that now.

[Devin Rousso]

Created attachment 260944 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 260944 [details]
Patch

Clearing flags on attachment: 260944

Committed r189593: <http://trac.webkit.org/changeset/189593>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.