Bug 148435 – storage/domstorage/events/basic-body-attribute.html is flaky

• Status: REOPENED
• Component: WebCore Misc.

[Alexey Proskuryakov]

storage/domstorage/events/basic-body-attribute.html became flaky on Mavericks, Yosemite and ELF WK2 bots around a week ago (first failure on August 18th).

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fdomstorage%2F&showExpectations=true&revision=188905

--- /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/storage/domstorage/events/basic-body-attribute-expected.txt
+++ /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/storage/domstorage/events/basic-body-attribute-actual.txt
@@ -57,41 +57,46 @@
 Reset storage event list
 storageEventList = new Array()
 storage.setItem('FOO', 'BAR')
-PASS storageEventList.length is 1
-PASS storageEventList[0].key is "FOO"
+FAIL got at least 2, expected only 1 events
+FAIL storageEventList.length should be 1. Was 2.
+FAIL storageEventList[0].key should be FOO. Was .
 PASS storageEventList[0].oldValue is null
-PASS storageEventList[0].newValue is "BAR"
+FAIL storageEventList[0].newValue should be BAR (of type string). Was null (of type object).
 storage.setItem('FU', 'BAR')
 storage.setItem('a', '1')
 storage.setItem('b', '2')
 storage.setItem('b', '3')
-PASS storageEventList.length is 5
-PASS storageEventList[1].key is "FU"
+FAIL got at least 6, expected only 5 events
+FAIL storageEventList.length should be 5. Was 6.
+FAIL storageEventList[1].key should be FU. Was FOO.
 PASS storageEventList[1].oldValue is null
 PASS storageEventList[1].newValue is "BAR"
-PASS storageEventList[2].key is "a"
+FAIL storageEventList[2].key should be a. Was FU.
 PASS storageEventList[2].oldValue is null
-PASS storageEventList[2].newValue is "1"
-PASS storageEventList[3].key is "b"
+FAIL storageEventList[2].newValue should be 1. Was BAR.
+FAIL storageEventList[3].key should be b. Was a.
 PASS storageEventList[3].oldValue is null
-PASS storageEventList[3].newValue is "2"
+FAIL storageEventList[3].newValue should be 2. Was 1.
 PASS storageEventList[4].key is "b"
-PASS storageEventList[4].oldValue is "2"
-PASS storageEventList[4].newValue is "3"
+FAIL storageEventList[4].oldValue should be 2 (of type string). Was null (of type object).
+FAIL storageEventList[4].newValue should be 3. Was 2.
 storage.removeItem('FOO')
-PASS storageEventList.length is 6
-PASS storageEventList[5].key is "FOO"
-PASS storageEventList[5].oldValue is "BAR"
-PASS storageEventList[5].newValue is null
+FAIL got at least 7, expected only 6 events
+FAIL storageEventList.length should be 6. Was 7.
+FAIL storageEventList[5].key should be FOO. Was b.
+FAIL storageEventList[5].oldValue should be BAR. Was 2.
+FAIL storageEventList[5].newValue should be null (of type object). Was 3 (of type string).
 storage.removeItem('FU')
-PASS storageEventList.length is 7
-PASS storageEventList[6].key is "FU"
+FAIL got at least 8, expected only 7 events
+FAIL storageEventList.length should be 7. Was 8.
+FAIL storageEventList[6].key should be FU. Was FOO.
 PASS storageEventList[6].oldValue is "BAR"
 PASS storageEventList[6].newValue is null
 storage.clear()
-PASS storageEventList.length is 8
-PASS storageEventList[7].key is ""
-PASS storageEventList[7].oldValue is null
+FAIL got at least 9, expected only 8 events
+FAIL storageEventList.length should be 8. Was 9.
+FAIL storageEventList[7].key should be . Was FU.
+FAIL storageEventList[7].oldValue should be null (of type object). Was BAR (of type string).
 PASS storageEventList[7].newValue is null

[Alexey Proskuryakov]

Some timing change must have happened, but the test failed before last week, too. ASan bot was seeing it.

r188597 was the first revision where this occurred on non-ASan bots.

[Ryan Haddad]

Still seeing the flakiness:
https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/17797

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fdomstorage%2Fevents%2Fbasic-body-attribute.html

[Ryan Haddad]

Created attachment 262893 [details]
Patch

[Ryan Haddad]

*** Bug 149969 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 262893 [details]
Patch

Clearing flags on attachment: 262893

Committed r190877: <http://trac.webkit.org/changeset/190877>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Re-opening, as this is not fixed.