Bug 148433 - [GStreamer] "method" property for the webkitwebsrc element
Summary: [GStreamer] "method" property for the webkitwebsrc element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-25 08:52 PDT by Philippe Normand
Modified: 2015-08-26 02:51 PDT (History)
3 users (show)

See Also:


Attachments
patch (4.02 KB, patch)
2015-08-25 09:00 PDT, Philippe Normand
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-08-25 08:52:43 PDT
The GStreamer uridownloader element makes use of this property in some cases for DASH. See also https://bugzilla.gnome.org/show_bug.cgi?id=752413

So we should also add this property in webkitwebsrc, the patch is trivial.
Comment 1 Philippe Normand 2015-08-25 09:00:39 PDT
Created attachment 259847 [details]
patch
Comment 2 Carlos Garcia Campos 2015-08-26 00:27:05 PDT
Comment on attachment 259847 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259847&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:116
> +    GUniquePtr<gchar> method;

method is quite confusing name, we can't change the property name, of course, but at least the variable could be httpMethod or something like that, I didn't know what this was about until I read the full patch.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:269
> +            0, static_cast<GParamFlags>(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));

nullptr.
Comment 3 Philippe Normand 2015-08-26 02:51:44 PDT
Committed r188961: <http://trac.webkit.org/changeset/188961>