Bug 148433 – [GStreamer] "method" property for the webkitwebsrc element

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

The GStreamer uridownloader element makes use of this property in some cases for DASH. See also https://bugzilla.gnome.org/show_bug.cgi?id=752413

So we should also add this property in webkitwebsrc, the patch is trivial.

[Philippe Normand]

Created attachment 259847 [details]
patch

[Carlos Garcia Campos]

Comment on attachment 259847 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259847&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:116
> +    GUniquePtr<gchar> method;

method is quite confusing name, we can't change the property name, of course, but at least the variable could be httpMethod or something like that, I didn't know what this was about until I read the full patch.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:269
> +            0, static_cast<GParamFlags>(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));

nullptr.

[Philippe Normand]

Committed r188961: <http://trac.webkit.org/changeset/188961>