Bug 148432 – Remove PassRefPtr style check rule

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gyuyoung Kim]

PassRefPtr is being removed. Thus style rule needs to be removed as well. If not, many style rule violations will happens whenever removal patch is uploaded.

[Gyuyoung Kim]

Created attachment 259842 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 259842 [details]
Patch

Clearing flags on attachment: 259842

Committed r188940: <http://trac.webkit.org/changeset/188940>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andy Estes]

Looks like this broke some webkitpy tests. From <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/16667/steps/webkitpy-test/logs/stdio>:

[933/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_pass_other_type_ptr_in_function failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3648, in test_pass_other_type_ptr_in_function
      'Local variables should never be PassOtherTypePtr (see '
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check
      self.perform_pass_ptr_check(code))
  AssertionError: 'Local variables should never be PassOtherTypePtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]' != ''


[1221/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_pass_ref_ptr_in_function failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3639, in test_pass_ref_ptr_in_function
      'Local variables should never be PassRefPtr (see '
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check
      self.perform_pass_ptr_check(code))
  AssertionError: 'Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]' != ''

[1226/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_ref_ptr_parameter_value failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3682, in test_ref_ptr_parameter_value
      'The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]')
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check
      self.perform_pass_ptr_check(code))
  AssertionError: 'The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]' != ''

[Gyuyoung Kim]

(In reply to comment #4)
> Looks like this broke some webkitpy tests. From

Yes, I'm going to upload a fix to Bug 148463.

https://bugs.webkit.org/show_bug.cgi?id=148463