Bug 148432 - Remove PassRefPtr style check rule
Summary: Remove PassRefPtr style check rule
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 147974 148463
  Show dependency tree / graph
 
Reported: 2015-08-25 07:38 PDT by Gyuyoung Kim
Modified: 2015-08-25 21:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2015-08-25 07:39 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-08-25 07:38:08 PDT 
PassRefPtr is being removed. Thus style rule needs to be removed as well. If not, many style rule violations will happens whenever removal patch is uploaded.
Comment 1 Gyuyoung Kim 2015-08-25 07:39:02 PDT 
Created attachment 259842 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-25 18:03:10 PDT 
Comment on attachment 259842 [details]
Patch

Clearing flags on attachment: 259842

Committed r188940: <http://trac.webkit.org/changeset/188940>
Comment 3 WebKit Commit Bot 2015-08-25 18:03:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Andy Estes 2015-08-25 21:28:26 PDT 
Looks like this broke some webkitpy tests. From <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/16667/steps/webkitpy-test/logs/stdio>:

[933/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_pass_other_type_ptr_in_function failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3648, in test_pass_other_type_ptr_in_function
      'Local variables should never be PassOtherTypePtr (see '
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check
      self.perform_pass_ptr_check(code))
  AssertionError: 'Local variables should never be PassOtherTypePtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]' != ''


[1221/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_pass_ref_ptr_in_function failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3639, in test_pass_ref_ptr_in_function
      'Local variables should never be PassRefPtr (see '
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check
      self.perform_pass_ptr_check(code))
  AssertionError: 'Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]' != ''

[1226/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_ref_ptr_parameter_value failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3682, in test_ref_ptr_parameter_value
      'The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]')
    File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check
      self.perform_pass_ptr_check(code))
  AssertionError: 'The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]' != ''
Comment 5 Gyuyoung Kim 2015-08-25 21:30:04 PDT 
(In reply to comment #4)
> Looks like this broke some webkitpy tests. From

Yes, I'm going to upload a fix to Bug 148463.

https://bugs.webkit.org/show_bug.cgi?id=148463