Bug 148412 - Web Inspector: Rendering Frames pie chart should use the needsLayout/updateLayout idiom
Summary: Web Inspector: Rendering Frames pie chart should use the needsLayout/updateLa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-24 19:07 PDT by Matt Baker
Modified: 2015-08-25 10:55 PDT (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (12.54 KB, patch)
2015-08-24 19:24 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (12.52 KB, patch)
2015-08-25 10:24 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-08-24 19:07:46 PDT 
* SUMMARY
Rendering Frames pie chart should use the needsLayout/updateLayout idiom. The chart should also allow existing values to be updated, so we don't have to rebuild the legend every time a frame is added to the timeline.
Comment 1 Radar WebKit Bug Importer 2015-08-24 19:08:20 PDT 
<rdar://problem/22413304>
Comment 2 Matt Baker 2015-08-24 19:24:05 PDT 
Created attachment 259807 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2015-08-25 10:06:34 PDT 
Comment on attachment 259807 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=259807&action=review

> Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js:205
> +            else
> +                return item.value;

No else.
Comment 4 Matt Baker 2015-08-25 10:24:12 PDT 
Created attachment 259856 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2015-08-25 10:55:22 PDT 
Comment on attachment 259856 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 259856

Committed r188916: <http://trac.webkit.org/changeset/188916>
Comment 6 WebKit Commit Bot 2015-08-25 10:55:26 PDT 
All reviewed patches have been landed.  Closing bug.