Bug 148394 - Add support for setting JSC options from a file.
Summary: Add support for setting JSC options from a file.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-24 14:26 PDT by Mark Lam
Modified: 2015-08-24 14:52 PDT (History)
1 user (show)

See Also:

Attachments
the fix. (4.09 KB, patch)
2015-08-24 14:36 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
fix 2: use ASCIICType this time. (4.14 KB, patch)
2015-08-24 14:45 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-08-24 14:26:57 PDT 
This is needed for environments where the JSC executable does not have access to environmental variables.  This is only needed for debugging, and is currently guarded under a #define USE_OPTIONS_FILE in Options.cpp, and is disabled by default.
Comment 1 Mark Lam 2015-08-24 14:36:06 PDT 
Created attachment 259772 [details]
the fix.
Comment 2 WebKit Commit Bot 2015-08-24 14:38:32 PDT 
Attachment 259772 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Options.cpp:443:  Use equivelent function in <wtf/ASCIICType.h> instead of the isspace() function.  [runtime/ctype_function] [4]
ERROR: Source/JavaScriptCore/runtime/Options.cpp:469:  Use equivelent function in <wtf/ASCIICType.h> instead of the isspace() function.  [runtime/ctype_function] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-08-24 14:45:49 PDT 
Created attachment 259780 [details]
fix 2: use ASCIICType this time.
Comment 4 Saam Barati 2015-08-24 14:48:17 PDT 
Comment on attachment 259780 [details]
fix 2: use ASCIICType this time.

r=me
Comment 5 Mark Lam 2015-08-24 14:52:40 PDT 
Thanks.  Landed in r188887: <http://trac.webkit.org/r188887>.