https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/24008/steps/compile-webkit/logs/stdio ../../Tools/WebKitTestRunner/PlatformWebView.h:30:33: fatal error: WebKit/WKFoundation.h: No such file or directory #include <WebKit/WKFoundation.h>
Created attachment 259738 [details] Patch
Comment on attachment 259738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259738&action=review > Tools/WebKitTestRunner/PlatformWebView.h:30 > +#if PLATFORM(COCOA) PLATFORM(COCOA) macro is used 35 line too. So isn't it would be good to move "#include <WebKit/WKFoundation.h> inside the macro ? For example, http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h#L36
Comment on attachment 259738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259738&action=review >> Tools/WebKitTestRunner/PlatformWebView.h:30 >> +#if PLATFORM(COCOA) > > PLATFORM(COCOA) macro is used 35 line too. So isn't it would be good to move "#include <WebKit/WKFoundation.h> inside the macro ? > > For example, http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h#L36 That would be fine too. It just has to be before the first WK_API_ENABLED.
Created attachment 259739 [details] Patch
(In reply to comment #3) > Comment on attachment 259738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259738&action=review > > >> Tools/WebKitTestRunner/PlatformWebView.h:30 > >> +#if PLATFORM(COCOA) > > > > PLATFORM(COCOA) macro is used 35 line too. So isn't it would be good to move "#include <WebKit/WKFoundation.h> inside the macro ? > > > > For example, http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h#L36 > > That would be fine too. It just has to be before the first WK_API_ENABLED. Thanks for the review. I moved the header file to PLATFORM(COCOA) guard.
Comment on attachment 259739 [details] Patch Rejecting attachment 259739 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 259739, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 188839 = 91a25641d6e666cbb91b29e02f143576e92522fc r188840 = d837bc87816f2e752cadd17919f79f0af0cd9d16 r188841 = 3ff214b4c03f49f6a34a49325d7e649e3a20ea55 r188842 = 6ba1ab28e51011b68ab5b65944576ea3e456cd8b r188843 = aab0d7c1c0fc76d5f985c54e758c9dbca5855a2e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/96879
Oops.. Ossy, already fixed the build. http://trac.webkit.org/changeset/188840 I close this issue.
(In reply to comment #7) > Oops.. > Ossy, already fixed the build. > http://trac.webkit.org/changeset/188840 > > I close this issue. Oops, sorry for the duplicated work. :( Unfortunately I only checked the review queue before fixing. I will check the pending commits too next time.