RESOLVED FIXED 148367
DFG::InsertionSet should be tolerant of occasional out-of-order insertions 
https://bugs.webkit.org/show_bug.cgi?id=148367
Summary DFG::InsertionSet should be tolerant of occasional out-of-order insertions
Filip Pizlo
Reported 2015-08-22 19:40:44 PDT
Patch forthcoming.
Attachments
the patch (16.66 KB, patch)
2015-08-22 19:45 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-08-22 19:45:47 PDT
Created attachment 259730 [details] the patch
Geoffrey Garen
Comment 2 2015-08-24 10:45:03 PDT
Comment on attachment 259730 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=259730&action=review r=me > Source/JavaScriptCore/ChangeLog:19 > + It seems like it would be best to just lift this restrictions. restriction
Saam Barati
Comment 3 2015-08-24 10:46:03 PDT
Comment on attachment 259730 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=259730&action=review r=me > Source/JavaScriptCore/dfg/DFGInsertionSet.cpp:35 > + for (size_t index = m_insertions.size() - 1; index--;) { Even though this is checked at the call site for this function, it might be nice for documentation's sake to assert that the last element's index is larger than what we're inserting.
Filip Pizlo
Comment 4 2015-08-24 13:59:29 PDT
(In reply to comment #2) > Comment on attachment 259730 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259730&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:19 > > + It seems like it would be best to just lift this restrictions. > > restriction Fixed.
Filip Pizlo
Comment 5 2015-08-24 13:59:37 PDT
(In reply to comment #3) > Comment on attachment 259730 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259730&action=review > > r=me > > > Source/JavaScriptCore/dfg/DFGInsertionSet.cpp:35 > > + for (size_t index = m_insertions.size() - 1; index--;) { > > Even though this is checked at the call site for this function, it might be > nice for documentation's sake to assert that the last element's index is > larger than what we're inserting. Done.
Filip Pizlo
Comment 6 2015-08-24 14:11:48 PDT
Landed in http://trac.webkit.org/changeset/188879
Note You need to log in before you can comment on or make changes to this bug.