Bug 148364 - Web Inspector: Drop webkit prefixes from animation, keyframes and transform
Summary: Web Inspector: Drop webkit prefixes from animation, keyframes and transform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-22 19:08 PDT by Timothy Hatcher
Modified: 2015-08-24 11:59 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.54 KB, patch)
2015-08-22 19:10 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-08-22 19:08:01 PDT
We could have dropped these a while ago.
Comment 1 Radar WebKit Bug Importer 2015-08-22 19:08:20 PDT
<rdar://problem/22393110>
Comment 2 Timothy Hatcher 2015-08-22 19:10:58 PDT
Created attachment 259727 [details]
Patch
Comment 3 WebKit Commit Bot 2015-08-23 09:31:29 PDT
Comment on attachment 259727 [details]
Patch

Clearing flags on attachment: 259727

Committed r188837: <http://trac.webkit.org/changeset/188837>
Comment 4 WebKit Commit Bot 2015-08-23 09:31:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2015-08-24 11:27:57 PDT
Comment on attachment 259727 [details]
Patch

There are a number of listeners for "webkitAnimationEnd". Do these also need to change to "animationEnd"?

    Views/DashboardContainerView.js
    193:            dashboardView.element.removeEventListener("webkitAnimationEnd", animationEnded);
    200:            dashboardView.element.addEventListener("webkitAnimationEnd", animationEnded);
    226:            dashboardView.element.removeEventListener("webkitAnimationEnd", animationEnded);
    237:            dashboardView.element.addEventListener("webkitAnimationEnd", animationEnded);

    Views/DefaultDashboardView.js
    167:                container.removeEventListener("webkitAnimationEnd", animationEnded);
    177:            container.addEventListener("webkitAnimationEnd", animationEnded);

    Views/DOMTreeElement.js
    102:        this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this));

    Views/TextEditor.js
    963:        this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this));
Comment 6 Timothy Hatcher 2015-08-24 11:59:07 PDT
Good catch. Fixed in bug 148385.