WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148364
Web Inspector: Drop webkit prefixes from animation, keyframes and transform
https://bugs.webkit.org/show_bug.cgi?id=148364
Summary
Web Inspector: Drop webkit prefixes from animation, keyframes and transform
Timothy Hatcher
Reported
2015-08-22 19:08:01 PDT
We could have dropped these a while ago.
Attachments
Patch
(17.54 KB, patch)
2015-08-22 19:10 PDT
,
Timothy Hatcher
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-08-22 19:08:20 PDT
<
rdar://problem/22393110
>
Timothy Hatcher
Comment 2
2015-08-22 19:10:58 PDT
Created
attachment 259727
[details]
Patch
WebKit Commit Bot
Comment 3
2015-08-23 09:31:29 PDT
Comment on
attachment 259727
[details]
Patch Clearing flags on attachment: 259727 Committed
r188837
: <
http://trac.webkit.org/changeset/188837
>
WebKit Commit Bot
Comment 4
2015-08-23 09:31:33 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5
2015-08-24 11:27:57 PDT
Comment on
attachment 259727
[details]
Patch There are a number of listeners for "webkitAnimationEnd". Do these also need to change to "animationEnd"? Views/DashboardContainerView.js 193: dashboardView.element.removeEventListener("webkitAnimationEnd", animationEnded); 200: dashboardView.element.addEventListener("webkitAnimationEnd", animationEnded); 226: dashboardView.element.removeEventListener("webkitAnimationEnd", animationEnded); 237: dashboardView.element.addEventListener("webkitAnimationEnd", animationEnded); Views/DefaultDashboardView.js 167: container.removeEventListener("webkitAnimationEnd", animationEnded); 177: container.addEventListener("webkitAnimationEnd", animationEnded); Views/DOMTreeElement.js 102: this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this)); Views/TextEditor.js 963: this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this));
Timothy Hatcher
Comment 6
2015-08-24 11:59:07 PDT
Good catch. Fixed in
bug 148385
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug