Bug 148314 - Web Inspector: Unit should have checkmark, not Unchanged in visual sidebar
Summary: Web Inspector: Unit should have checkmark, not Unchanged in visual sidebar
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix, InRadar
Depends on:
Blocks: 147563
  Show dependency tree / graph
 
Reported: 2015-08-21 10:44 PDT by Timothy Hatcher
Modified: 2015-11-20 12:59 PST (History)
8 users (show)

See Also:

Attachments
Video (1.66 MB, video/quicktime)
2015-08-21 20:36 PDT, Timothy Hatcher 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-08-21 10:44:18 PDT 
See the video in this tweet. https://twitter.com/webkit/status/634766855375323137

The unit popup menu has Unchanged checked, when it should have px checked.
Comment 1 Radar WebKit Bug Importer 2015-08-21 10:44:33 PDT 
<rdar://problem/22381266>
Comment 2 Timothy Hatcher 2015-08-21 20:27:53 PDT 
I am not seeing this in TOT now. Seems like it is fixed.
Comment 3 Timothy Hatcher 2015-08-21 20:34:44 PDT 
Actually this reproduces if you ever pick Unchanged.
Comment 4 Timothy Hatcher 2015-08-21 20:36:12 PDT 
Created attachment 259705 [details]
Video

It seems if you pick Unchanged once, the menu will keep it checked, even if the unchanged values has a unit in the menu that should be selected.

Sounds like we need to reset selectedIndex before showing the menu or at sometime.
Comment 5 Devin Rousso 2015-09-11 22:40:41 PDT 
Are you still seeing this issue?  If so, could you please provide some specific steps to reproduce?  I can't seem to get this to happen for me...
Comment 6 BJ Burg 2015-11-20 12:59:33 PST 
I cannot reproduce this either. Closing for now.