Bug 148286 - DFG should have a KnownBooleanUse for cases where we are required to know that the child is a boolean and it's not OK to speculate
Summary: DFG should have a KnownBooleanUse for cases where we are required to know tha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 145204
  Show dependency tree / graph
 
Reported: 2015-08-20 20:37 PDT by Filip Pizlo
Modified: 2015-08-20 21:00 PDT (History)
12 users (show)

See Also:

Attachments
the patch (12.83 KB, patch)
2015-08-20 20:38 PDT, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-20 20:37:10 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-08-20 20:38:52 PDT 
Created attachment 259581 [details]
the patch
Comment 2 Benjamin Poulain 2015-08-20 20:47:52 PDT 
Comment on attachment 259581 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259581&action=review

> Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79
> +            if (m_state.forNode(edge).m_type & ~BooleanUse)

Fishy. Is that BooleanUse right?
Comment 3 Filip Pizlo 2015-08-20 20:56:11 PDT 
(In reply to comment #2)
> Comment on attachment 259581 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259581&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79
> > +            if (m_state.forNode(edge).m_type & ~BooleanUse)
> 
> Fishy. Is that BooleanUse right?

Yeah. :-)  Fixed locally.
Comment 4 Filip Pizlo 2015-08-20 21:00:02 PDT 
Landed in http://trac.webkit.org/changeset/188747