WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148283
REGRESSION (
r188581
): Web Inspector: Console user command isn't visible when it's expected to be
https://bugs.webkit.org/show_bug.cgi?id=148283
Summary
REGRESSION (r188581): Web Inspector: Console user command isn't visible when ...
Nikita Vasilyev
Reported
2015-08-20 19:40:36 PDT
<button onclick="console.log('Clicked')">Click me</button> Steps: 1. > 1+1 2. Click the button 3. > 1+1 Expected:
> 1+1
< 2 [Log] Clicked
> 1+1
< 2 Actual:
> 1+1
< 2 [Log] Clicked < 2 "> 1+1" before the last line is missing.
Attachments
Patch
(1.77 KB, patch)
2015-08-20 19:45 PDT
,
Nikita Vasilyev
no flags
Details
Formatted Diff
Diff
Patch
(3.55 KB, patch)
2015-08-21 23:16 PDT
,
Nikita Vasilyev
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-08-20 19:41:02 PDT
<
rdar://problem/22374022
>
Nikita Vasilyev
Comment 2
2015-08-20 19:45:36 PDT
Created
attachment 259568
[details]
Patch
Blaze Burg
Comment 3
2015-08-21 09:26:58 PDT
Comment on
attachment 259568
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=259568&action=review
> Source/WebInspectorUI/ChangeLog:7 > +
You should explain why this regressed, and why the fix is correct.
> Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:288 > + this._lastCommited = "";
Please rename this to _lastCommitted. It is spelled incorrectly. =)
Nikita Vasilyev
Comment 4
2015-08-21 23:16:21 PDT
Created
attachment 259713
[details]
Patch
WebKit Commit Bot
Comment 5
2015-08-24 08:57:22 PDT
Comment on
attachment 259713
[details]
Patch Clearing flags on attachment: 259713 Committed
r188862
: <
http://trac.webkit.org/changeset/188862
>
WebKit Commit Bot
Comment 6
2015-08-24 08:57:26 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug