Bug 148275 - [Win] Cleanup some Windows WebCore files
Summary: [Win] Cleanup some Windows WebCore files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 8
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 148240
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-20 17:56 PDT by Brent Fulgham
Modified: 2016-01-04 10:10 PST (History)
3 users (show)

See Also:


Attachments
Patch (26.07 KB, patch)
2015-08-20 18:05 PDT, Brent Fulgham
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-08-20 17:56:55 PDT
Correct various Windows MIDL declarations and C++11/C++14 issues in Windows-specific WebCore code.
Comment 1 Brent Fulgham 2015-08-20 18:05:47 PDT
Created attachment 259545 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-20 18:08:33 PDT
Attachment 259545 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1154:  AccessiblePopupMenu::get_accParent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1163:  AccessiblePopupMenu::get_accChildCount is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1172:  AccessiblePopupMenu::get_accChild is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1186:  AccessiblePopupMenu::get_accName is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1191:  AccessiblePopupMenu::get_accValue is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1212:  AccessiblePopupMenu::get_accDescription is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1218:  AccessiblePopupMenu::get_accRole is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1237:  AccessiblePopupMenu::get_accState is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1251:  AccessiblePopupMenu::get_accHelp is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1257:  AccessiblePopupMenu::get_accKeyboardShortcut is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1263:  AccessiblePopupMenu::get_accFocus is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1269:  AccessiblePopupMenu::get_accSelection is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1275:  AccessiblePopupMenu::get_accDefaultAction is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/PopupMenuWin.cpp:1420:  AccessiblePopupMenu::get_accHelpTopic is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/win/WCDataObject.cpp:212:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 15 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2016-01-04 09:45:52 PST
Whoops! I never landed this!
Comment 4 Brent Fulgham 2016-01-04 10:10:23 PST
Committed r194535: <http://trac.webkit.org/changeset/194535>