Bug 148271 - Replace uses of StaticLock with Lock
Summary: Replace uses of StaticLock with Lock
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-20 17:16 PDT by Anders Carlsson
Modified: 2015-08-21 11:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (21.20 KB, patch)
2015-08-20 17:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-08-20 17:16:43 PDT 
Replace uses of StaticLock with Lock
Comment 1 Anders Carlsson 2015-08-20 17:17:39 PDT 
Created attachment 259536 [details]
Patch
Comment 2 Geoffrey Garen 2015-08-21 11:57:49 PDT 
Don't we need to do something like marking Lock's constructor constexpr in order to avoid a static initializer?
Comment 3 Anders Carlsson 2015-08-21 11:59:18 PDT 
(In reply to comment #2)
> Don't we need to do something like marking Lock's constructor constexpr in
> order to avoid a static initializer?

Yup. I did that (and landed those patches) but they broke the Mavericks build due to compiler bugs. I'm going to re-land the patches once we can drop Mavericks support.