Bug 148261 - [iOS] Emoji's descent is way too large
Summary: [iOS] Emoji's descent is way too large
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-20 16:08 PDT by Myles C. Maxfield
Modified: 2015-08-20 19:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.68 KB, patch)
2015-08-20 16:18 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (8.69 KB, patch)
2015-08-20 17:43 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-20 16:08:05 PDT 
Emoji's descent is way too large
Comment 1 Myles C. Maxfield 2015-08-20 16:18:45 PDT 
Created attachment 259515 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-20 16:21:08 PDT 
Comment on attachment 259515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259515&action=review

> Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:-275
> -    if (m_platformData.isEmoji()) {

This should match the size clamping code too
Comment 3 Myles C. Maxfield 2015-08-20 17:43:38 PDT 
Created attachment 259541 [details]
Patch
Comment 4 Myles C. Maxfield 2015-08-20 17:45:36 PDT 
<rdar://problem/22194708>
Comment 5 Myles C. Maxfield 2015-08-20 18:26:15 PDT 
This is no longer necessary because of https://bugs.webkit.org/show_bug.cgi?id=148265
Comment 6 Myles C. Maxfield 2015-08-20 19:13:52 PDT 
Fixed by r188737